Bug 196359 – CodeBlock::jettison() should disallow repatching its own calls

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Tadeu Zagallo]

<rdar://problem/48973663>

[Tadeu Zagallo]

Created attachment 366192 [details]
Patch

[Saam Barati]

Comment on attachment 366192 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366192&action=review

> Source/JavaScriptCore/ChangeLog:12
> +        OSR exit address while unlinking all the incoming CallLinkInfos latter in

latter => later

[Saam Barati]

Comment on attachment 366192 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366192&action=review

> Source/JavaScriptCore/ChangeLog:17
> +        Change it so that we set a flag, `clearedByJettison`, in all the CallLinkInfos
> +        owned by the CodeBlock being jettisoned. If the flag is set, we will avoid
> +        repatching the call during unlinking.

It took me a few minutes to agree that this is safe, but maybe it's worth expanding on in a sentence or two. The beginning of this call should never be reachable again after the CodeBlock is jettisoned.

[Saam Barati]

Comment on attachment 366192 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366192&action=review

> JSTests/stress/call-link-info-osrexit-repatch.js:3
> +function foo(a, b) {

style nit: use 4 space indent

[Tadeu Zagallo]

Created attachment 366203 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 366203 [details]
Patch for landing

Clearing flags on attachment: 366203

Committed r243626: <https://trac.webkit.org/changeset/243626>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.