Bug 196237 - Remove some now-unnecessary dynamic class lookup
Summary: Remove some now-unnecessary dynamic class lookup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-25 18:23 PDT by Tim Horton
Modified: 2019-03-25 23:08 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.46 KB, patch)
2019-03-25 18:23 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (2.58 MB, application/zip)
2019-03-25 20:32 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2019-03-25 18:23:11 PDT
Remove some now-unnecessary dynamic class lookup
Comment 1 Tim Horton 2019-03-25 18:23:24 PDT
Created attachment 365934 [details]
Patch
Comment 2 WebKit Commit Bot 2019-03-25 20:30:28 PDT
Comment on attachment 365934 [details]
Patch

Rejecting attachment 365934 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 365934, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=365934&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=196237&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 365934 from bug 196237.
Fetching: https://bugs.webkit.org/attachment.cgi?id=365934
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebKit/ChangeLog
	M	Source/WebKit/Shared/DocumentEditingContext.mm
	M	Tools/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Tools/ChangeLog' is out of date
W: 7577e916c39810a35cce9c955f48bb5845d98dfd and refs/remotes/origin/master differ, using rebase:
:040000 040000 9d7008a5d4ba440797e9bba44a10f2667380d735 659275059d95d1ad80b8046c292d885e1122e9a9 M	Source
:040000 040000 92a018eadb594723bb59cf1b4f837d725180b1db 5fe5e44210e0551603f32e043ca1dc6dd0218960 M	Tools
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebKit/ChangeLog
	M	Source/WebKit/Shared/DocumentEditingContext.mm
	M	Tools/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Tools/ChangeLog' is out of date
W: 7577e916c39810a35cce9c955f48bb5845d98dfd and refs/remotes/origin/master differ, using rebase:
:040000 040000 9d7008a5d4ba440797e9bba44a10f2667380d735 659275059d95d1ad80b8046c292d885e1122e9a9 M	Source
:040000 040000 92a018eadb594723bb59cf1b4f837d725180b1db 5fe5e44210e0551603f32e043ca1dc6dd0218960 M	Tools
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: https://webkit-queues.webkit.org/results/11668172
Comment 3 EWS Watchlist 2019-03-25 20:32:00 PDT
Comment on attachment 365934 [details]
Patch

Attachment 365934 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11667666

New failing tests:
fast/visual-viewport/ios/min-scale-greater-than-one.html
Comment 4 EWS Watchlist 2019-03-25 20:32:02 PDT
Created attachment 365938 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 5 Tim Horton 2019-03-25 21:18:23 PDT
Comment on attachment 365934 [details]
Patch

wat
Comment 6 WebKit Commit Bot 2019-03-25 21:45:18 PDT
Comment on attachment 365934 [details]
Patch

Clearing flags on attachment: 365934

Committed r243484: <https://trac.webkit.org/changeset/243484>
Comment 7 WebKit Commit Bot 2019-03-25 21:45:20 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-03-25 21:46:18 PDT
<rdar://problem/49246094>
Comment 9 Alexey Proskuryakov 2019-03-25 22:48:23 PDT
(In reply to Tim Horton from comment #5)

> wat

Bug 196236
Comment 10 Tim Horton 2019-03-25 23:08:39 PDT
(In reply to Alexey Proskuryakov from comment #9)
> (In reply to Tim Horton from comment #5)
> 
> > wat
> 
> Bug 196236

That was not the part I was watting, see comment #2.