Bug 196210 – Get rid of WebPage::m_shouldResetDrawingAreaAfterSuspend flag

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Get rid of WebPage::m_shouldResetDrawingAreaAfterSuspend flag and use the drawing area identifier instead to reset the DrawingArea in the WebProcess whenever the UIProcess did.
This is less error-prone and guarantees that the WebProcess and the UIProcess can reliably communicate via DrawingArea IPC.

[Chris Dumez]

<rdar://problem/48681326>

[Chris Dumez]

Created attachment 365885 [details]
Patch

[Tim Horton]

seems reasonable to me (but no r? ?)

[Chris Dumez]

(In reply to Tim Horton from comment #3)
> seems reasonable to me (but no r? ?)

Oops, it's Monday.

[Geoffrey Garen]

Comment on attachment 365885 [details]
Patch

r=me, since Tim didn't complain that numbers should always count up :P

[WebKit Commit Bot]

Comment on attachment 365885 [details]
Patch

Rejecting attachment 365885 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 365885, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=365885&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=196210&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 365885 from bug 196210.
Fetching: https://bugs.webkit.org/attachment.cgi?id=365885
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebKit/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/WebKit/ChangeLog' is out of date
W: 73838d6a01ce16a312311b8329d4cd4cca5c638e and refs/remotes/origin/master differ, using rebase:
:040000 040000 028b6442b4be5bac4e79bb6d348ab54c9e5aede9 0574addc16e1cee7c921acedf98913efa3c95281 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebKit/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/WebKit/ChangeLog' is out of date
W: 73838d6a01ce16a312311b8329d4cd4cca5c638e and refs/remotes/origin/master differ, using rebase:
:040000 040000 028b6442b4be5bac4e79bb6d348ab54c9e5aede9 0574addc16e1cee7c921acedf98913efa3c95281 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
From https://git.webkit.org/git/WebKit
   1f7f7ee9f80..a9a2b47dd47  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 243451 = 1f7f7ee9f80f303efe0e23fd56a756a8f0ad4171
r243452 = 3403c502d4cb52c876200beb20cee9ff573df185
r243453 = a9a2b47dd4700634d2f40c33e1a612af8a5464df
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: https://webkit-queues.webkit.org/results/11663578

[WebKit Commit Bot]

Comment on attachment 365885 [details]
Patch

Clearing flags on attachment: 365885

Committed r243461: <https://trac.webkit.org/changeset/243461>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.