Bug 196192 - [WinCairo] WebProcessDataStoreParameters.h(32): error C2653: 'SandboxExtension': is not a class or namespace name
Summary: [WinCairo] WebProcessDataStoreParameters.h(32): error C2653: 'SandboxExtensio...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-24 21:24 PDT by Fujii Hironori
Modified: 2019-03-24 22:10 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.18 KB, patch)
2019-03-24 21:27 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2019-03-24 21:24:39 PDT 
WinCairo builds get broken.

> "C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.14.26428\bin\Hostx64\x64\cl.exe"  (...) -c ..\..\Source\WebKit\WebProcess\MediaCache\WebMediaKeyStorageManager.cpp
> C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Shared\WebProcessDataStoreParameters.h(32): error C2653: 'SandboxExtension': is not a class or namespace name
> C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Shared\WebProcessDataStoreParameters.h(32): error C3646: 'applicationCacheDirectoryExtensionHandle': unknown override specifier
> C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Shared\WebProcessDataStoreParameters.h(32): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
> C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Shared\WebProcessDataStoreParameters.h(35): error C2653: 'SandboxExtension': is not a class or namespace name
> C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Shared\WebProcessDataStoreParameters.h(35): error C3646: 'webSQLDatabaseDirectoryExtensionHandle': unknown override specifier
> C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Shared\WebProcessDataStoreParameters.h(35): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
> C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Shared\WebProcessDataStoreParameters.h(37): error C2653: 'SandboxExtension': is not a class or namespace name
> C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Shared\WebProcessDataStoreParameters.h(37): error C3646: 'mediaCacheDirectoryExtensionHandle': unknown override specifier
> C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Shared\WebProcessDataStoreParameters.h(37): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
> C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Shared\WebProcessDataStoreParameters.h(39): error C2653: 'SandboxExtension': is not a class or namespace name
> C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Shared\WebProcessDataStoreParameters.h(39): error C3646: 'mediaKeyStorageDirectoryExtensionHandle': unknown override specifier
> C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Shared\WebProcessDataStoreParameters.h(39): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
> C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Shared\WebProcessDataStoreParameters.h(41): error C2653: 'SandboxExtension': is not a class or namespace name
> C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Shared\WebProcessDataStoreParameters.h(41): error C3646: 'javaScriptConfigurationDirectoryExtensionHandle': unknown override specifier
> C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Shared\WebProcessDataStoreParameters.h(41): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
Comment 1 Fujii Hironori 2019-03-24 21:27:42 PDT 
Created attachment 365846 [details]
Patch
Comment 2 WebKit Commit Bot 2019-03-24 22:09:34 PDT 
Comment on attachment 365846 [details]
Patch

Clearing flags on attachment: 365846

Committed r243430: <https://trac.webkit.org/changeset/243430>
Comment 3 WebKit Commit Bot 2019-03-24 22:09:35 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-03-24 22:10:19 PDT 
<rdar://problem/49204922>