Bug 196189 - Reflect HTMLLinkElement.as according to the spec
Summary: Reflect HTMLLinkElement.as according to the spec
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: Other
Hardware: All All
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-24 09:13 PDT by Rob Buis
Modified: 2019-03-26 20:04 PDT (History)
9 users (show)

See Also:

Attachments
Patch (3.59 KB, patch)
2019-03-24 09:31 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (10.33 KB, patch)
2019-03-24 10:23 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.69 MB, application/zip)
2019-03-24 12:27 PDT, EWS Watchlist 		no flags Details
Patch (17.65 KB, patch)
2019-03-24 12:35 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (18.00 KB, patch)
2019-03-24 14:54 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2019-03-24 09:13:04 PDT 
Import preload/reflected-as-value.html
Comment 1 Rob Buis 2019-03-24 09:31:21 PDT 
Created attachment 365831 [details]
Patch
Comment 2 Rob Buis 2019-03-24 10:23:32 PDT 
Created attachment 365834 [details]
Patch
Comment 3 EWS Watchlist 2019-03-24 12:27:58 PDT 
Comment on attachment 365834 [details]
Patch

Attachment 365834 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11646301

New failing tests:
imported/w3c/web-platform-tests/html/dom/reflection-metadata.html
Comment 4 EWS Watchlist 2019-03-24 12:27:59 PDT 
Created attachment 365835 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 5 Rob Buis 2019-03-24 12:35:22 PDT 
Created attachment 365836 [details]
Patch
Comment 6 Alexey Proskuryakov 2019-03-24 13:40:53 PDT 
This patch also changes WebCore behavior, can you reflect that in the title please (both bug and patch).
Comment 7 Rob Buis 2019-03-24 14:54:55 PDT 
Created attachment 365838 [details]
Patch
Comment 8 WebKit Commit Bot 2019-03-25 03:31:01 PDT 
Comment on attachment 365838 [details]
Patch

Clearing flags on attachment: 365838

Committed r243435: <https://trac.webkit.org/changeset/243435>
Comment 9 WebKit Commit Bot 2019-03-25 03:31:02 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2019-03-25 03:32:45 PDT 
<rdar://problem/49210689>
Comment 11 Darin Adler 2019-03-26 20:04:12 PDT 
Comment on attachment 365838 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365838&action=review

> Source/WebCore/html/HTMLLinkElement.cpp:248
> +        return as.convertToASCIILowercase();

In other similar call sites, we return ASCIILiteral constants rather than calling convertToASCIILowercase. Ideally I’d like to see a consistent idiom for our implementations of enumerated attributes.

To get realty fancy, maybe we could even have the IDL generate appropriate reflection getters/setters for them without hand-writing the C++ code.