Bug 196154 - Placate exception check validation in genericTypedArrayViewProtoFuncLastIndexOf().
Summary: Placate exception check validation in genericTypedArrayViewProtoFuncLastIndex...
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
Keywords: InRadar
Depends on:
Reported: 2019-03-22 10:38 PDT by Mark Lam
Modified: 2019-03-24 08:42 PDT (History)
7 users (show)

See Also:

proposed patch. (3.00 KB, patch)
2019-03-22 10:42 PDT, Mark Lam
no flags Details | Formatted Diff | Diff
proposed patch. (3.59 KB, patch)
2019-03-22 10:47 PDT, Mark Lam
fpizlo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2019-03-22 10:38:47 PDT
Comment 1 Mark Lam 2019-03-22 10:42:16 PDT
Created attachment 365742 [details]
proposed patch.
Comment 2 Mark Lam 2019-03-22 10:47:52 PDT
Created attachment 365743 [details]
proposed patch.
Comment 3 Mark Lam 2019-03-22 10:59:53 PDT
Thanks for the review.  Landed in r243391: <http://trac.webkit.org/r243391>.
Comment 4 Dominik Inführ 2019-03-24 03:30:52 PDT
Hi! web-assembly-link-error-exception-check.js is failing on 32-bit because WebAssembly isn't supported. Shouldn't this test be moved into JSTests/wasm/stress?
Comment 5 Dominik Inführ 2019-03-24 08:42:41 PDT
I've uploaded a patch that moves this test into JSTests/wasm/stress: https://bugs.webkit.org/show_bug.cgi?id=196187