Enable IPC sending and receiving non-default-constructible types
Created attachment 365684 [details] Patch
Comment on attachment 365684 [details] Patch Attachment 365684 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11610196 Number of test failures exceeded the failure limit.
Created attachment 365694 [details] Archive of layout-test-results from ews105 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 365684 [details] Patch Attachment 365684 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11610091 Number of test failures exceeded the failure limit.
Created attachment 365695 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
This patch seems to break lot of API tests. iOS: https://ews-build.webkit-uat.org/#/builders/20/builds/2243 (94 new API Tests failures) macOS: https://ews-build.webkit-uat.org/#/builders/19/builds/2398 (61 new API Tests failures) If this is a false positive, please let us know.
Retried the builds to confirm (by clicking 'Rebuild' button on Buildbot build page). Failed again: iOS: https://ews-build.webkit-uat.org/#/builders/20/builds/2250 (93 new API Tests failures) mac: https://ews-build.webkit-uat.org/#/builders/19/builds/2409 (61 new API Tests failures) If this is a false positive, please let us know.
Created attachment 365778 [details] Patch
(In reply to Aakash Jain from comment #7) > If this is a false positive, please let us know. It was definitely not a false positive. With my first patch, anything on Cocoa platforms or Windows that sent a SharedMemory::Handle would crash because the default move constructor and operator= do not zero out the moved-from object. My second patch fixes this.
(In reply to Alex Christensen from comment #9) > (In reply to Aakash Jain from comment #7) > > If this is a false positive, please let us know. > It was definitely not a false positive. With my first patch, anything on Cocoa platforms or Windows that sent a SharedMemory::Handle would crash because the default move constructor and operator= do not zero out the moved-from object. > My second patch fixes this. Thanks. API tests pass now. iOS: https://ews-build.webkit-uat.org/#/builders/20/builds/2281 macOS: https://ews-build.webkit-uat.org/#/builders/19/builds/2441
Comment on attachment 365778 [details] Patch r=me
http://trac.webkit.org/r243460
<rdar://problem/49229221>
WinCairo port builds get broken. https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Debug%20%28Build%29/builds/7627 > FAILED: Source/WebKit/CMakeFiles/WebKit.dir/Platform/win/SharedMemoryWin.cpp.obj > "C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.14.26428\bin\Hostx64\x64\cl.exe" (...) -c ..\..\Source\WebKit\Platform\win\SharedMemoryWin.cpp > C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.14.26428\include\utility(688): error C2440: '=': cannot convert from 'int' to 'HANDLE ' > C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.14.26428\include\utility(688): note: Conversion from integral type to pointer type requires reinterpret_cast, C-style cast or function-style cast > ..\..\Source\WebKit\Platform\win\SharedMemoryWin.cpp(44): note: see reference to function template instantiation '_Ty *std::exchange<HANDLE,int>(_Ty &,_Other &&)' being compiled > with > [ > _Ty=HANDLE, > _Other=int > ]
Committed r243479: <https://trac.webkit.org/changeset/243479>
It's interesting that the constructor on line 37 worked but operator= did not.
Yeah. But, GCC and Clang also can't compile. https://godbolt.org/z/Rz_fVO