Bug 196125 - [Web Animations] com.apple.WebKit.WebContent.Development at com.apple.WebCore: WebCore::WebAnimation::timeToNextTick const + 757
Summary: [Web Animations] com.apple.WebKit.WebContent.Development at com.apple.WebCore...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-21 18:58 PDT by Antoine Quint
Modified: 2019-03-22 06:47 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.51 KB, patch)
2019-03-21 19:03 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2019-03-21 18:58:50 PDT 
We eventually hit the ASSERT_NOT_REACHED in WebAnimation::timeToNextTick with the following command:

run-webkit-tests --debug animations/stacking-context-not-fill-forwards.html --iterations=1000 --exit-after-n-failures=1
Comment 1 Antoine Quint 2019-03-21 18:59:05 PDT 
<rdar://problem/46520059>
Comment 2 Antoine Quint 2019-03-21 19:03:20 PDT 
Created attachment 365664 [details]
Patch
Comment 3 Dean Jackson 2019-03-21 19:04:09 PDT 
Comment on attachment 365664 [details]
Patch

Where is the test?
Comment 4 Antoine Quint 2019-03-21 19:08:17 PDT 
(In reply to Dean Jackson from comment #3)
> Comment on attachment 365664 [details]
> Patch
> 
> Where is the test?

The API itself wouldn’t let you input a value close enough to the boundary to be within the epsilon because they get rounded to the nearest millisecond. We'll know this issue is fixed as this caused crashes in Debug builds for a number of tests, this should now go down to 0.
Comment 5 WebKit Commit Bot 2019-03-22 06:47:01 PDT 
Comment on attachment 365664 [details]
Patch

Clearing flags on attachment: 365664

Committed r243374: <https://trac.webkit.org/changeset/243374>
Comment 6 WebKit Commit Bot 2019-03-22 06:47:02 PDT 
All reviewed patches have been landed.  Closing bug.