Bug 196051 - [ContentChangeObserver] Start tracking implicit transitions at touchStart
Summary: [ContentChangeObserver] Start tracking implicit transitions at touchStart
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-20 20:34 PDT by zalan
Modified: 2019-03-21 11:49 PDT (History)
4 users (show)

See Also:


Attachments
Patch (19.85 KB, patch)
2019-03-20 21:23 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (19.84 KB, patch)
2019-03-21 08:54 PDT, zalan
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-03-20 20:34:15 PDT
up until touchEnd.
Comment 1 Radar WebKit Bug Importer 2019-03-20 21:01:28 PDT
<rdar://problem/49092952>
Comment 2 zalan 2019-03-20 21:23:31 PDT
Created attachment 365481 [details]
Patch
Comment 3 zalan 2019-03-21 08:54:19 PDT
Created attachment 365549 [details]
Patch
Comment 4 Simon Fraser (smfr) 2019-03-21 11:06:46 PDT
Comment on attachment 365549 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365549&action=review

> Source/WebCore/page/ios/ContentChangeObserver.cpp:357
>          }
> +        // It's way too early to notify the client.

Remove.

> Source/WebCore/page/ios/ContentChangeObserver.h:173
> +        CancelledTransition,

Canceled?
Comment 5 zalan 2019-03-21 11:49:59 PDT
Committed r243307: <https://trac.webkit.org/changeset/243307>