Bug 195972 – Web Inspector: Runtime: lazily create the agent

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

.

[Radar WebKit Bug Importer]

<rdar://problem/49039655>

[Devin Rousso]

Created attachment 365268 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 365268 [details]
Patch

Rejecting attachment 365268 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 365268, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=365268&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=195972&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 365268 from bug 195972.
Fetching: https://bugs.webkit.org/attachment.cgi?id=365268
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 13 diffs from patch file(s).
patching file Source/JavaScriptCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp
Hunk #1 succeeded at 72 with fuzz 2.
Hunk #2 succeeded at 79 with fuzz 2 (offset -2 lines).
Hunk #3 succeeded at 312 with fuzz 2 (offset 4 lines).
patching file Source/JavaScriptCore/inspector/agents/InspectorRuntimeAgent.cpp
patching file Source/JavaScriptCore/inspector/agents/InspectorRuntimeAgent.h
patching file Source/JavaScriptCore/inspector/agents/JSGlobalObjectRuntimeAgent.cpp
patching file Source/JavaScriptCore/inspector/agents/JSGlobalObjectRuntimeAgent.h
patching file Source/WebCore/inspector/InspectorController.cpp
patching file Source/WebCore/inspector/WorkerInspectorController.cpp
Hunk #1 FAILED at 72.
Hunk #2 succeeded at 166 (offset -1 lines).
1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/inspector/WorkerInspectorController.cpp.rej
patching file Source/WebCore/inspector/agents/page/PageRuntimeAgent.cpp
patching file Source/WebCore/inspector/agents/page/PageRuntimeAgent.h
patching file Source/WebCore/inspector/agents/worker/WorkerRuntimeAgent.cpp
patching file Source/WebCore/inspector/agents/worker/WorkerRuntimeAgent.h

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/11581344

[Devin Rousso]

Created attachment 365362 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 365362 [details]
Patch

Clearing flags on attachment: 365362

Committed r243243: <https://trac.webkit.org/changeset/243243>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.