Bug 195894 - [iOS] Native selection views sometimes appear in hidden editable areas after losing focus
Summary: [iOS] Native selection views sometimes appear in hidden editable areas after ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-18 10:27 PDT by Wenson Hsieh
Modified: 2019-03-18 14:23 PDT (History)
6 users (show)

See Also:

Attachments
Patch (23.83 KB, patch)
2019-03-18 12:14 PDT, Wenson Hsieh 		thorton: review+
Details | Formatted Diff | Diff
Patch for landing (23.82 KB, patch)
2019-03-18 13:44 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2019-03-18 10:27:12 PDT 
<rdar://problem/48849989>
Comment 1 Wenson Hsieh 2019-03-18 12:14:52 PDT 
Created attachment 365043 [details]
Patch
Comment 2 Tim Horton 2019-03-18 12:17:13 PDT 
Comment on attachment 365043 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365043&action=review

> Source/WebKit/ChangeLog:22
> +        Rename elementIsTransparentOrFullyClipped to editableRootIsTransparentOrFullyClipped, and additional compute

additional*ly*
Comment 3 Wenson Hsieh 2019-03-18 12:18:17 PDT 
Comment on attachment 365043 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365043&action=review

> Source/WebKit/ChangeLog:9
> +        On certain websites, focus is moved away from an editable element while maintaing a selection inside the

Also, "maintaing" :|

>> Source/WebKit/ChangeLog:22
>> +        Rename elementIsTransparentOrFullyClipped to editableRootIsTransparentOrFullyClipped, and additional compute
> 
> additional*ly*

(OOPS!) Will fix.
Comment 4 Wenson Hsieh 2019-03-18 13:44:22 PDT 
Created attachment 365055 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2019-03-18 14:22:59 PDT 
Comment on attachment 365055 [details]
Patch for landing

Clearing flags on attachment: 365055

Committed r243102: <https://trac.webkit.org/changeset/243102>