Bug 195850 - [GTK] [WPE] Fix compilation errors due to undefined ALWAYS_LOG_IF
Summary: [GTK] [WPE] Fix compilation errors due to undefined ALWAYS_LOG_IF
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-16 02:47 PDT by Diego Pino
Modified: 2019-03-16 04:58 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.21 KB, patch)
2019-03-16 02:50 PDT, Diego Pino 		no flags Details | Formatted Diff | Diff
Patch (1.22 KB, patch)
2019-03-16 02:51 PDT, Diego Pino 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2019-03-16 02:47:20 PDT 
WPE and GTK build bots failed after https://trac.webkit.org/changeset/243033/webkit.

The changeset introduced new functions ALWAYS_LOG_IF and alike when RELEASE_LOG_DISABLED is false. These macros need to be defined as empty when !RELEASE_LOG_DISABLED.
Comment 1 Diego Pino 2019-03-16 02:50:19 PDT 
Created attachment 364926 [details]
Patch
Comment 2 Diego Pino 2019-03-16 02:51:59 PDT 
Created attachment 364927 [details]
Patch
Comment 3 WebKit Commit Bot 2019-03-16 04:26:20 PDT 
Comment on attachment 364927 [details]
Patch

Clearing flags on attachment: 364927

Committed r243040: <https://trac.webkit.org/changeset/243040>
Comment 4 WebKit Commit Bot 2019-03-16 04:26:22 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-03-16 04:58:08 PDT 
<rdar://problem/48952567>