Bug 195817 - Total not showing in JetStream2
Summary: Total not showing in JetStream2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P1 Normal
Assignee: Jon Davis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-15 13:34 PDT by Jon Davis
Modified: 2019-03-15 15:10 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.11 KB, patch)
2019-03-15 13:41 PDT, Jon Davis
no flags Details | Formatted Diff | Diff
Patch (1.11 KB, patch)
2019-03-15 14:07 PDT, Jon Davis
no flags Details | Formatted Diff | Diff
Patch (1.74 KB, patch)
2019-03-15 14:13 PDT, Jon Davis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Davis 2019-03-15 13:34:33 PDT
There is a bug in setting the browser elements for changing the status and summary of the test.
Comment 1 Jon Davis 2019-03-15 13:41:37 PDT
Created attachment 364832 [details]
Patch
Comment 2 Ryosuke Niwa 2019-03-15 13:50:19 PDT
Comment on attachment 364832 [details]
Patch

Use let instead of var?
Comment 3 Jon Davis 2019-03-15 14:07:11 PDT
Created attachment 364839 [details]
Patch
Comment 4 Jon Davis 2019-03-15 14:13:14 PDT
Created attachment 364841 [details]
Patch
Comment 5 EWS 2019-03-15 14:17:22 PDT
Comment on attachment 364841 [details]
Patch

Rejecting attachment 364841 [details] from review queue.

jond@apple.com does not have reviewer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.
Comment 6 WebKit Commit Bot 2019-03-15 14:45:47 PDT
Comment on attachment 364841 [details]
Patch

Clearing flags on attachment: 364841

Committed r243013: <https://trac.webkit.org/changeset/243013>
Comment 7 WebKit Commit Bot 2019-03-15 14:45:49 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-03-15 15:10:32 PDT
<rdar://problem/48940241>