Bug 195677 - [GStreamer][WebRTC] Create sps/pps for all frames to please Chrome
Summary: [GStreamer][WebRTC] Create sps/pps for all frames to please Chrome
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thibault Saunier
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-13 07:28 PDT by Thibault Saunier
Modified: 2019-03-19 14:40 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.57 KB, patch)
2019-03-13 07:29 PDT, Thibault Saunier 		no flags Details | Formatted Diff | Diff
Patch (3.93 KB, patch)
2019-03-13 13:32 PDT, Thibault Saunier 		no flags Details | Formatted Diff | Diff
Patch for landing (3.93 KB, patch)
2019-03-19 13:51 PDT, Thibault Saunier 		no flags Details | Formatted Diff | Diff
Patch for landing (3.92 KB, patch)
2019-03-19 14:00 PDT, Thibault Saunier 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thibault Saunier 2019-03-13 07:28:43 PDT 
[GStreamer][WebRTC] Create sps/pps for all frames to please Chrome
Comment 1 Thibault Saunier 2019-03-13 07:29:08 PDT 
Created attachment 364531 [details]
Patch
Comment 2 Thibault Saunier 2019-03-13 13:32:05 PDT 
Created attachment 364569 [details]
Patch
Comment 3 Thibault Saunier 2019-03-19 13:51:03 PDT 
Created attachment 365224 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2019-03-19 13:52:19 PDT 
Comment on attachment 365224 [details]
Patch for landing

Rejecting attachment 365224 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 365224, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/11570187
Comment 5 Thibault Saunier 2019-03-19 14:00:01 PDT 
Created attachment 365226 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2019-03-19 14:39:11 PDT 
Comment on attachment 365226 [details]
Patch for landing

Clearing flags on attachment: 365226

Committed r243170: <https://trac.webkit.org/changeset/243170>
Comment 7 WebKit Commit Bot 2019-03-19 14:39:12 PDT 
All reviewed patches have been landed.  Closing bug.