Bug 195673 - [GStreamer][WebRTC] Do not sync encoder on the clock
Summary: [GStreamer][WebRTC] Do not sync encoder on the clock
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thibault Saunier
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-13 07:14 PDT by Thibault Saunier
Modified: 2019-03-13 09:31 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.75 KB, patch)
2019-03-13 07:15 PDT, Thibault Saunier 		no flags Details | Formatted Diff | Diff
Patch for landing (1.75 KB, patch)
2019-03-13 08:06 PDT, Thibault Saunier 		no flags Details | Formatted Diff | Diff
Patch for landing (1.76 KB, patch)
2019-03-13 08:30 PDT, Thibault Saunier 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thibault Saunier 2019-03-13 07:14:54 PDT 
[GStreamer][WebRTC] Do not sync encoder on the clock
Comment 1 Thibault Saunier 2019-03-13 07:15:18 PDT 
Created attachment 364527 [details]
Patch
Comment 2 Philippe Normand 2019-03-13 07:41:48 PDT 
Comment on attachment 364527 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364527&action=review

> Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:145
> +        g_object_set(sink, "sync", FALSE, NULL);

Please at least remain consistent with the code below and use nullptr :)
Comment 3 Thibault Saunier 2019-03-13 08:06:21 PDT 
Created attachment 364535 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2019-03-13 08:08:10 PDT 
Comment on attachment 364535 [details]
Patch for landing

Rejecting attachment 364535 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 364535, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/11489929
Comment 5 Thibault Saunier 2019-03-13 08:30:11 PDT 
Created attachment 364536 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2019-03-13 09:08:20 PDT 
Comment on attachment 364536 [details]
Patch for landing

Clearing flags on attachment: 364536

Committed r242883: <https://trac.webkit.org/changeset/242883>
Comment 7 WebKit Commit Bot 2019-03-13 09:08:22 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-03-13 09:31:06 PDT 
<rdar://problem/48849834>