Bug 195662 - [Win][PlayStation] Remove WebCore::standardUserAgentForURL
Summary: [Win][PlayStation] Remove WebCore::standardUserAgentForURL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-12 21:13 PDT by Fujii Hironori
Modified: 2019-03-13 00:49 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.89 KB, patch)
2019-03-12 21:46 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff
Patch (3.66 KB, patch)
2019-03-12 23:17 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2019-03-12 21:13:11 PDT
[Win] Remove WebCore::standardUserAgentForURL

Requested by:

  [webkit-dev] PSA: WebCore::Quirks should define the logic to determine if a particular site specific quirk is needed or not
  https://lists.webkit.org/pipermail/webkit-dev/2019-March/030530.html
Comment 1 Fujii Hironori 2019-03-12 21:46:19 PDT
Created attachment 364511 [details]
Patch
Comment 2 Ross Kirsling 2019-03-12 22:45:41 PDT
LGTM assuming it suffices to remove it.

Do you want to remove it from UserAgentPlayStation right away too?
Comment 3 Fujii Hironori 2019-03-12 23:17:21 PDT
Created attachment 364516 [details]
Patch
Comment 4 Fujii Hironori 2019-03-13 00:48:41 PDT
Comment on attachment 364516 [details]
Patch

Clearing flags on attachment: 364516

Committed r242847: <https://trac.webkit.org/changeset/242847>
Comment 5 Fujii Hironori 2019-03-13 00:48:44 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-03-13 00:49:30 PDT
<rdar://problem/48839947>