Bug 195660 - Fix testbmalloc build
Summary: Fix testbmalloc build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-12 20:25 PDT by Sam Weinig
Modified: 2019-03-13 11:10 PDT (History)
5 users (show)

See Also:


Attachments
Patch (8.05 KB, patch)
2019-03-12 20:33 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2019-03-12 20:25:39 PDT
Fix testbmalloc build
Comment 1 Sam Weinig 2019-03-12 20:33:14 PDT
Created attachment 364504 [details]
Patch
Comment 2 Build Bot 2019-03-12 20:34:41 PDT
Attachment 364504 [details] did not pass style-queue:


ERROR: Source/bmalloc/bmalloc/StdLibExtras.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/bmalloc/bmalloc/StdLibExtras.h:36:  bitwise_cast is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2019-03-13 10:43:26 PDT
Comment on attachment 364504 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2019-03-13 11:09:06 PDT
Comment on attachment 364504 [details]
Patch

Clearing flags on attachment: 364504

Committed r242892: <https://trac.webkit.org/changeset/242892>
Comment 5 WebKit Commit Bot 2019-03-13 11:09:08 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-03-13 11:10:20 PDT
<rdar://problem/48854597>