Bug 195602 – Move IDB storage in private browsing mode to NetworkProcess

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

Move IDB storage in private browsing mode to NetworkProcess

[youenn fablet]

Created attachment 364347 [details]
Patch

[youenn fablet]

Created attachment 364417 [details]
Patch

[youenn fablet]

Created attachment 364681 [details]
Rebasing

[Alex Christensen]

Comment on attachment 364681 [details]
Rebasing

View in context: https://bugs.webkit.org/attachment.cgi?id=364681&action=review

Is it really this simple?

> Source/WebKit/WebProcess/Databases/WebDatabaseProvider.cpp:-73
> -        auto result = m_idbEphemeralConnectionMap.add(sessionID.sessionID(), nullptr);

m_idbEphemeralConnectionMap is now unused.

[Brady Eidson]

(In reply to Alex Christensen from comment #4)
> Comment on attachment 364681 [details]
> Rebasing
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=364681&action=review
> 
> Is it really this simple?

Yup.

There's two IDBServers - In-process and remote.
There's two IDBBackingStores - SQLite and in-memory

All we had to do was change the mix and match.

👍

[youenn fablet]

Created attachment 364695 [details]
Removing unneeded member field

[WebKit Commit Bot]

Comment on attachment 364695 [details]
Removing unneeded member field

Clearing flags on attachment: 364695

Committed r242975: <https://trac.webkit.org/changeset/242975>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/48906494>

[Truitt Savell]

The changes in https://trac.webkit.org/changeset/242975/webkit

appears to have broken:
imported/w3c/IndexedDB-private-browsing/idbobjectstore_createIndex6-event_order.html

History:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2FIndexedDB-private-browsing%2Fidbobjectstore_createIndex6-event_order.html

I was able to reproduce this locally using command:
run-webkit-tests imported/w3c/IndexedDB-private-browsing/idbobjectstore_createIndex6-event_order.html --iterations 500 -f

The test fails often when run on 242975 and not at all on 242974.

[youenn fablet]

(In reply to Truitt Savell from comment #10)
> The changes in https://trac.webkit.org/changeset/242975/webkit
> 
> appears to have broken:
> imported/w3c/IndexedDB-private-browsing/idbobjectstore_createIndex6-
> event_order.html
> 
> History:
> https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.
> html#showAllRuns=true&tests=imported%2Fw3c%2FIndexedDB-private-
> browsing%2Fidbobjectstore_createIndex6-event_order.html
> 
> I was able to reproduce this locally using command:
> run-webkit-tests
> imported/w3c/IndexedDB-private-browsing/idbobjectstore_createIndex6-
> event_order.html --iterations 500 -f
> 
> The test fails often when run on 242975 and not at all on 242974.

Looking at the dashboard, the corresponding non private browsing is also flaky with the same kind of failure.

Given we updated private IDB to be closer to regular IDB, it might be that an existing flakiness is now also happening with private IDB.