Rename originsMatch in originSerializationsMatch. That will make it clearer the intent of this method.
Created attachment 364286 [details] Patch
Comment on attachment 364286 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364286&action=review > Source/WebCore/ChangeLog:3 > + Rename originsMatch in originSerializationsMatch Will serializedOriginsMatch be a better name?
Comment on attachment 364286 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364286&action=review >> Source/WebCore/ChangeLog:3 >> + Rename originsMatch in originSerializationsMatch > > Will serializedOriginsMatch be a better name? Anymore, they are more or less the same. LGTM. r=me.
(In reply to Jiewen Tan from comment #3) > Comment on attachment 364286 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=364286&action=review > > >> Source/WebCore/ChangeLog:3 > >> + Rename originsMatch in originSerializationsMatch > > > > Will serializedOriginsMatch be a better name? > > Anymore, they are more or less the same. LGTM. r=me. I mean anyway...
Created attachment 364399 [details] Patch for landing
Comment on attachment 364399 [details] Patch for landing Clearing flags on attachment: 364399 Committed r242804: <https://trac.webkit.org/changeset/242804>
All reviewed patches have been landed. Closing bug.
<rdar://problem/48816174>
(In reply to Jiewen Tan from comment #2) > Comment on attachment 364286 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=364286&action=review > > > Source/WebCore/ChangeLog:3 > > + Rename originsMatch in originSerializationsMatch > > Will serializedOriginsMatch be a better name? Sounds better indeed, changed in the landing patch.