Bug 195572 - Rename originsMatch in originSerializationsMatch
Summary: Rename originsMatch in originSerializationsMatch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-11 14:24 PDT by youenn fablet
Modified: 2019-03-13 09:49 PDT (History)
5 users (show)

See Also:


Attachments
Patch (7.95 KB, patch)
2019-03-11 14:26 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (7.93 KB, patch)
2019-03-12 10:16 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-03-11 14:24:09 PDT
Rename originsMatch in originSerializationsMatch.
That will make it clearer the intent of this method.
Comment 1 youenn fablet 2019-03-11 14:26:42 PDT
Created attachment 364286 [details]
Patch
Comment 2 Jiewen Tan 2019-03-11 18:45:55 PDT
Comment on attachment 364286 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364286&action=review

> Source/WebCore/ChangeLog:3
> +        Rename originsMatch in originSerializationsMatch

Will serializedOriginsMatch be a better name?
Comment 3 Jiewen Tan 2019-03-11 18:52:28 PDT
Comment on attachment 364286 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364286&action=review

>> Source/WebCore/ChangeLog:3
>> +        Rename originsMatch in originSerializationsMatch
> 
> Will serializedOriginsMatch be a better name?

Anymore, they are more or less the same. LGTM. r=me.
Comment 4 Jiewen Tan 2019-03-11 18:52:45 PDT
(In reply to Jiewen Tan from comment #3)
> Comment on attachment 364286 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=364286&action=review
> 
> >> Source/WebCore/ChangeLog:3
> >> +        Rename originsMatch in originSerializationsMatch
> > 
> > Will serializedOriginsMatch be a better name?
> 
> Anymore, they are more or less the same. LGTM. r=me.

I mean anyway...
Comment 5 youenn fablet 2019-03-12 10:16:11 PDT
Created attachment 364399 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2019-03-12 11:08:23 PDT
Comment on attachment 364399 [details]
Patch for landing

Clearing flags on attachment: 364399

Committed r242804: <https://trac.webkit.org/changeset/242804>
Comment 7 WebKit Commit Bot 2019-03-12 11:08:24 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-03-12 11:33:03 PDT
<rdar://problem/48816174>
Comment 9 youenn fablet 2019-03-13 09:49:03 PDT
(In reply to Jiewen Tan from comment #2)
> Comment on attachment 364286 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=364286&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        Rename originsMatch in originSerializationsMatch
> 
> Will serializedOriginsMatch be a better name?

Sounds better indeed, changed in the landing patch.