Bug 195570 - Layout Test imported/w3c/web-platform-tests/IndexedDB/transaction-abort-request-error.html is failing
Summary: Layout Test imported/w3c/web-platform-tests/IndexedDB/transaction-abort-reque...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-11 13:36 PDT by Sihui Liu
Modified: 2019-03-12 12:29 PDT (History)
7 users (show)

See Also:


Attachments
Patch (4.50 KB, patch)
2019-03-11 13:39 PDT, Sihui Liu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2019-03-11 13:36:23 PDT
Request result should be undefined if it's never set.
Comment 1 Sihui Liu 2019-03-11 13:39:14 PDT
Created attachment 364282 [details]
Patch
Comment 2 Alex Christensen 2019-03-11 15:47:26 PDT
Comment on attachment 364282 [details]
Patch

Could we instead have this in the header?  Then we could remove all of these.

Result m_result { NullResultType::Undefined };
Comment 3 Sihui Liu 2019-03-11 18:30:20 PDT
(In reply to Alex Christensen from comment #2)
> Comment on attachment 364282 [details]
> Patch
> 
> Could we instead have this in the header?  Then we could remove all of these.
> 
> Result m_result { NullResultType::Undefined };

Tried this and it caused problem to forward declarations in IDBRequest.h, so I guess this doesn't work..
Comment 4 Brady Eidson 2019-03-12 11:33:56 PDT
Comment on attachment 364282 [details]
Patch

Hah.
Comment 5 WebKit Commit Bot 2019-03-12 12:28:46 PDT
Comment on attachment 364282 [details]
Patch

Clearing flags on attachment: 364282

Committed r242815: <https://trac.webkit.org/changeset/242815>
Comment 6 WebKit Commit Bot 2019-03-12 12:28:47 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-03-12 12:29:21 PDT
<rdar://problem/48818543>