Bug 195554 - Add web audio release logging
Summary: Add web audio release logging
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-11 07:36 PDT by Eric Carlson
Modified: 2019-03-11 13:19 PDT (History)
4 users (show)

See Also:

Attachments
Patch (52.98 KB, patch)
2019-03-11 10:13 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2019-03-11 07:36:15 PDT 
Add some web audio release logging
Comment 1 Radar WebKit Bug Importer 2019-03-11 08:04:27 PDT 
<rdar://problem/48767211>
Comment 2 Eric Carlson 2019-03-11 10:13:36 PDT 
Created attachment 364265 [details]
Patch
Comment 3 EWS Watchlist 2019-03-11 10:16:12 PDT 
Attachment 364265 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/webaudio/AudioNode.cpp:69:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 28 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 WebKit Commit Bot 2019-03-11 13:19:55 PDT 
Comment on attachment 364265 [details]
Patch

Clearing flags on attachment: 364265

Committed r242734: <https://trac.webkit.org/changeset/242734>
Comment 5 WebKit Commit Bot 2019-03-11 13:19:57 PDT 
All reviewed patches have been landed.  Closing bug.