Bug 195541 - Allow storage quota increase by default in WTR
Summary: Allow storage quota increase by default in WTR
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks: 195302
  Show dependency tree / graph
 
Reported: 2019-03-10 20:58 PDT by youenn fablet
Modified: 2019-03-11 12:39 PDT (History)
7 users (show)

See Also:

Attachments
Patch (10.44 KB, patch)
2019-03-10 21:09 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (10.56 KB, patch)
2019-03-10 21:12 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-03-10 20:58:47 PDT 
Update allowCacheStorageQuotaIncrease to setAllowStorageQuotaIncrease and set the default quota increase rule to allow by default
Comment 1 youenn fablet 2019-03-10 21:09:51 PDT 
Created attachment 364228 [details]
Patch
Comment 2 youenn fablet 2019-03-10 21:12:19 PDT 
Created attachment 364230 [details]
Patch
Comment 3 EWS Watchlist 2019-03-10 21:14:41 PDT 
Attachment 364230 [details] did not pass style-queue:


ERROR: Tools/WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:38:  The parameter name "quota" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Geoffrey Garen 2019-03-11 12:00:05 PDT 
Comment on attachment 364230 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2019-03-11 12:38:09 PDT 
Comment on attachment 364230 [details]
Patch

Clearing flags on attachment: 364230

Committed r242727: <https://trac.webkit.org/changeset/242727>
Comment 6 WebKit Commit Bot 2019-03-11 12:38:11 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-03-11 12:39:26 PDT 
<rdar://problem/48777555>