Bug 195496 - ParserError can be shrunk by 8 bytes
Summary: ParserError can be shrunk by 8 bytes
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Trivial
Assignee: Robin Morisset
Keywords: InRadar
Depends on:
Reported: 2019-03-08 17:04 PST by Robin Morisset
Modified: 2019-03-17 16:51 PDT (History)
8 users (show)

See Also:

Patch (1.19 KB, patch)
2019-03-08 17:06 PST, Robin Morisset
mark.lam: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (2.81 MB, application/zip)
2019-03-08 22:58 PST, EWS Watchlist
no flags Details
Patch (1.22 KB, patch)
2019-03-11 10:14 PDT, Robin Morisset
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Morisset 2019-03-08 17:04:48 PST
By shrinking two enums to 8 bits each.
Comment 1 Robin Morisset 2019-03-08 17:06:07 PST
Created attachment 364092 [details]
Comment 2 EWS Watchlist 2019-03-08 22:58:47 PST
Comment on attachment 364092 [details]

Attachment 364092 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11436310

New failing tests:
Comment 3 EWS Watchlist 2019-03-08 22:58:48 PST
Created attachment 364118 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6
Comment 4 Robin Morisset 2019-03-11 10:14:49 PDT
Created attachment 364266 [details]

Same patch, to verify that the bots were just flaky.
Comment 5 WebKit Commit Bot 2019-03-17 16:45:29 PDT
Comment on attachment 364266 [details]

Clearing flags on attachment: 364266

Committed r243053: <https://trac.webkit.org/changeset/243053>
Comment 6 WebKit Commit Bot 2019-03-17 16:45:31 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-03-17 16:51:39 PDT