Bug 195421 - [ContentChangeObserver] Check if visibility change happens while dispatching mouseMoved
Summary: [ContentChangeObserver] Check if visibility change happens while dispatching ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-07 11:02 PST by zalan
Modified: 2019-03-07 22:11 PST (History)
6 users (show)

See Also:


Attachments
Patch (7.10 KB, patch)
2019-03-07 11:06 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (7.44 KB, patch)
2019-03-07 20:45 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (7.42 KB, patch)
2019-03-07 21:06 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (7.40 KB, patch)
2019-03-07 21:27 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-03-07 11:02:52 PST
ssia
Comment 1 Radar WebKit Bug Importer 2019-03-07 11:03:34 PST
<rdar://problem/48682004>
Comment 2 zalan 2019-03-07 11:06:09 PST
Created attachment 363902 [details]
Patch
Comment 3 Simon Fraser (smfr) 2019-03-07 11:42:46 PST
Comment on attachment 363902 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363902&action=review

> Source/WebCore/ChangeLog:9
> +        Visibility change might be triggered synchronously while dispatching mouseMoved event.

Maybe say that this is restoring old behavior.
Comment 4 zalan 2019-03-07 20:45:18 PST
Created attachment 363981 [details]
Patch
Comment 5 zalan 2019-03-07 21:06:27 PST
Created attachment 363983 [details]
Patch
Comment 6 Wenson Hsieh 2019-03-07 21:12:24 PST
Comment on attachment 363983 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363983&action=review

> LayoutTests/fast/events/touch/ios/content-observation/visibility-change-happens-while-in-mousemoved.html:45
> +        setTimeout(testRunner.notifyDone(), 0);

Here too, setTimeout(testRunner.notifyDone(), …)
Comment 7 zalan 2019-03-07 21:27:11 PST
Created attachment 363986 [details]
Patch
Comment 8 WebKit Commit Bot 2019-03-07 22:11:46 PST
Comment on attachment 363986 [details]
Patch

Clearing flags on attachment: 363986

Committed r242635: <https://trac.webkit.org/changeset/242635>
Comment 9 WebKit Commit Bot 2019-03-07 22:11:47 PST
All reviewed patches have been landed.  Closing bug.