Bug 195408 - [GTK] Several InputMethodFilter tests are failing
Summary: [GTK] Several InputMethodFilter tests are failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-07 05:56 PST by Diego Pino
Modified: 2019-03-08 02:18 PST (History)
4 users (show)

See Also:


Attachments
Patch (5.35 KB, patch)
2019-03-07 06:09 PST, Diego Pino
no flags Details | Formatted Diff | Diff
Patch (5.36 KB, patch)
2019-03-07 06:22 PST, Diego Pino
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (2.47 MB, application/zip)
2019-03-07 08:31 PST, EWS Watchlist
no flags Details
Patch (5.40 KB, patch)
2019-03-07 09:03 PST, Diego Pino
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2019-03-07 05:56:39 PST
From https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/9917/steps/API%20tests/logs/stdio:


```
**FAIL** WebKit2.InputMethodFilterSimple



/home/slave/webkitgtk/gtk-linux-64-release/build/Tools/TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:101

Expected equality of these values:

  String("sendSimpleKeyEvent type=press keycode=6b text='k'")

    Which is: sendSimpleKeyEvent type=press keycode=6b text='k'

  events[4]

    Which is: sendSimpleKeyEvent type=press keycode=6B text='k'



**FAIL** WebKit2.InputMethodFilterUnicodeSequence



/home/slave/webkitgtk/gtk-linux-64-release/build/Tools/TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:129

Expected equality of these values:

  String("sendSimpleKeyEvent type=press keycode=ffe3")

    Which is: sendSimpleKeyEvent type=press keycode=ffe3

  events[0]

    Which is: sendSimpleKeyEvent type=press keycode=FFE3



**FAIL** WebKit2.InputMethodFilterComposeKey



/home/slave/webkitgtk/gtk-linux-64-release/build/Tools/TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:162

Expected equality of these values:

  String("sendKeyEventWithCompositionResults type=press keycode=6f")

    Which is: sendKeyEventWithCompositionResults type=press keycode=6f

  events[0]

    Which is: sendKeyEventWithCompositionResults type=press keycode=6F



**FAIL** WebKit2.InputMethodFilterContextEventsWithoutKeyEvents



/home/slave/webkitgtk/gtk-linux-64-release/build/Tools/TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:192

Expected equality of these values:

  String("sendKeyEventWithCompositionResults type=press keycode=ffffff (faked)")

    Which is: sendKeyEventWithCompositionResults type=press keycode=ffffff (faked)

  events[0]

    Which is: sendKeyEventWithCompositionResults type=press keycode=FFFFFF (faked)
```
Comment 1 Diego Pino 2019-03-07 06:09:53 PST
Created attachment 363870 [details]
Patch
Comment 2 EWS Watchlist 2019-03-07 06:11:53 PST
Attachment 363870 [details] did not pass style-queue:


ERROR: Tools/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Tools/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Diego Pino 2019-03-07 06:22:35 PST
Created attachment 363872 [details]
Patch
Comment 4 Diego Pino 2019-03-07 06:23:14 PST
Since https://bugs.webkit.org/show_bug.cgi?id=194752 hexadecimal keycodes are returned in upper letters. That made several tests fail, since they expected an hexadecimal value in lower letters.

On the other hand, there were two tests that compared a string to the result of a composited string, which is an UTF-8 string. So the expected string should be UTF-8 too.
Comment 5 Carlos Garcia Campos 2019-03-07 07:48:50 PST
Comment on attachment 363872 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363872&action=review

Thanks!

> Tools/ChangeLog:7
> +

Please, mention in the changelog that this regressed in r241751, that helps me to know whether I have to merge this in stable branches or not.
Comment 6 EWS Watchlist 2019-03-07 08:31:06 PST
Comment on attachment 363872 [details]
Patch

Attachment 363872 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11414025

New failing tests:
imported/w3c/web-platform-tests/webrtc/simplecall-no-ssrcs.https.html
Comment 7 EWS Watchlist 2019-03-07 08:31:08 PST
Created attachment 363876 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 8 Diego Pino 2019-03-07 09:03:25 PST
Created attachment 363880 [details]
Patch
Comment 9 WebKit Commit Bot 2019-03-08 02:18:33 PST
Comment on attachment 363880 [details]
Patch

Clearing flags on attachment: 363880

Committed r242638: <https://trac.webkit.org/changeset/242638>
Comment 10 WebKit Commit Bot 2019-03-08 02:18:35 PST
All reviewed patches have been landed.  Closing bug.