Bug 195349 – [Apple Pay] Untangle PKPaymentAuthorizationViewController from WebPaymentCoordinatorProxy

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andy Estes]

[Apple Pay] Untangle PKPaymentAuthorizationViewController from WebPaymentCoordinatorProxy

[Andy Estes]

Created attachment 363720 [details]
Patch

[Andy Estes]

Created attachment 363723 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/48625510>

[EWS Watchlist]

Attachment 363723 [details] did not pass style-queue:


ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:183:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andy Estes]

Created attachment 363724 [details]
Patch

[EWS Watchlist]

Attachment 363724 [details] did not pass style-queue:


ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:183:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andy Estes]

Created attachment 363802 [details]
Patch

[EWS Watchlist]

Attachment 363802 [details] did not pass style-queue:


ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:183:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andy Estes]

Created attachment 363805 [details]
Patch

[EWS Watchlist]

Attachment 363805 [details] did not pass style-queue:


ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:183:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andy Estes]

Created attachment 363808 [details]
Patch

[EWS Watchlist]

Attachment 363808 [details] did not pass style-queue:


ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:183:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Comment on attachment 363808 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363808&action=review

> Source/WebKit/Platform/cocoa/PaymentAuthorizationViewController.h:49
> +#if PLATFORM(IOS_FAMILY)
> +    PaymentAuthorizationViewController(PaymentAuthorizationPresenter::Client&, PKPaymentRequest *);
> +#endif
> +#if PLATFORM(MAC)
> +    PaymentAuthorizationViewController(PaymentAuthorizationPresenter::Client&, PKPaymentRequest *, PKPaymentAuthorizationViewController *);
> +#endif

This could be a default parameter.

[Andy Estes]

Created attachment 363904 [details]
Patch

[EWS Watchlist]

Attachment 363904 [details] did not pass style-queue:


ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:183:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andy Estes]

Created attachment 363923 [details]
Patch

[EWS Watchlist]

Attachment 363923 [details] did not pass style-queue:


ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:183:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 363923 [details]
Patch

Clearing flags on attachment: 363923

Committed r242616: <https://trac.webkit.org/changeset/242616>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.