[Apple Pay] Untangle PKPaymentAuthorizationViewController from WebPaymentCoordinatorProxy
Created attachment 363720 [details] Patch
Created attachment 363723 [details] Patch
<rdar://problem/48625510>
Attachment 363723 [details] did not pass style-queue: ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:183: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 1 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 363724 [details] Patch
Attachment 363724 [details] did not pass style-queue: ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:183: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 1 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 363802 [details] Patch
Attachment 363802 [details] did not pass style-queue: ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:183: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 1 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 363805 [details] Patch
Attachment 363805 [details] did not pass style-queue: ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:183: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 1 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 363808 [details] Patch
Attachment 363808 [details] did not pass style-queue: ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:183: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 1 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 363808 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363808&action=review > Source/WebKit/Platform/cocoa/PaymentAuthorizationViewController.h:49 > +#if PLATFORM(IOS_FAMILY) > + PaymentAuthorizationViewController(PaymentAuthorizationPresenter::Client&, PKPaymentRequest *); > +#endif > +#if PLATFORM(MAC) > + PaymentAuthorizationViewController(PaymentAuthorizationPresenter::Client&, PKPaymentRequest *, PKPaymentAuthorizationViewController *); > +#endif This could be a default parameter.
Created attachment 363904 [details] Patch
Attachment 363904 [details] did not pass style-queue: ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:183: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 1 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 363923 [details] Patch
Attachment 363923 [details] did not pass style-queue: ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:183: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 1 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 363923 [details] Patch Clearing flags on attachment: 363923 Committed r242616: <https://trac.webkit.org/changeset/242616>
All reviewed patches have been landed. Closing bug.