In order to support accessibility keyboard navigation in web view, the following API support is requested: Adding another option to AXUIElementsForSearchPredicate to search for keyboard focusable elements. If AXWebArea is passed in as the currentElement, then return the first keyboard focusable element inside the web view. If a random descendant of the web view is passed in as the currentElement, then find the next keyboard focusable elements in the DOM order. If no more keyboard focusable element is found, then pass the AXWebArea as the result.
rdar://problem/48578156
Created attachment 363683 [details] Patch
Comment on attachment 363683 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363683&action=review > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1163 > + Element* element = this->element(); this seems like it could be in AccessibilityObject, then it doesn't have to be virtual > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1166 > + return element->isFocusable(); this can be written like if (Element* element = this->element()) return element->isFocusable(); return false;
Created attachment 363716 [details] Patch
Comment on attachment 363716 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363716&action=review > Source/WebCore/accessibility/AccessibilityObject.cpp:197 > + can you undo this whitespace line change > Source/WebCore/accessibility/AccessibilityObject.cpp:3501 > + if (Element* element = this->element()) auto element
Created attachment 363718 [details] Patch
Comment on attachment 363718 [details] Patch Clearing flags on attachment: 363718 Committed r242528: <https://trac.webkit.org/changeset/242528>
All reviewed patches have been landed. Closing bug.