WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
195292
Web Inspector: Audit: show the version number in the UI
https://bugs.webkit.org/show_bug.cgi?id=195292
Summary
Web Inspector: Audit: show the version number in the UI
Devin Rousso
Reported
2019-03-04 12:34:29 PST
There should be some place for the current Audit version number (the minimum of the frontend and backend versions) to be visible so developers are able to target it when writing tests.
Attachments
Patch
(4.51 KB, patch)
2019-03-04 13:16 PST
,
Devin Rousso
mattbaker
: review+
Details
Formatted Diff
Diff
[Image] After Patch is applied
(746.26 KB, image/png)
2019-03-04 13:16 PST
,
Devin Rousso
no flags
Details
Patch
(4.51 KB, patch)
2019-03-04 14:19 PST
,
Devin Rousso
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2019-03-04 12:35:17 PST
<
rdar://problem/48572784
>
Devin Rousso
Comment 2
2019-03-04 13:16:16 PST
Created
attachment 363546
[details]
Patch
Devin Rousso
Comment 3
2019-03-04 13:16:35 PST
Created
attachment 363547
[details]
[Image] After Patch is applied
Matt Baker
Comment 4
2019-03-04 14:14:17 PST
Comment on
attachment 363546
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=363546&action=review
r=me
> Source/WebInspectorUI/UserInterface/Views/AuditNavigationSidebarPanel.css:81 > + font-size: 14px;
This should be 13px to match the font-size used for the body text of the "Editing Audits" .message-text-view element.
Devin Rousso
Comment 5
2019-03-04 14:19:06 PST
Created
attachment 363551
[details]
Patch
WebKit Commit Bot
Comment 6
2019-03-04 14:57:18 PST
Comment on
attachment 363551
[details]
Patch Clearing flags on attachment: 363551 Committed
r242395
: <
https://trac.webkit.org/changeset/242395
>
WebKit Commit Bot
Comment 7
2019-03-04 14:57:20 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug