Bug 195292 - Web Inspector: Audit: show the version number in the UI
Summary: Web Inspector: Audit: show the version number in the UI
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
Keywords: InRadar
Depends on: WebInspectorAuditTab
  Show dependency treegraph
Reported: 2019-03-04 12:34 PST by Devin Rousso
Modified: 2019-03-04 14:57 PST (History)
5 users (show)

See Also:

Patch (4.51 KB, patch)
2019-03-04 13:16 PST, Devin Rousso
mattbaker: review+
Details | Formatted Diff | Diff
[Image] After Patch is applied (746.26 KB, image/png)
2019-03-04 13:16 PST, Devin Rousso
no flags Details
Patch (4.51 KB, patch)
2019-03-04 14:19 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-03-04 12:34:29 PST
There should be some place for the current Audit version number (the minimum of the frontend and backend versions) to be visible so developers are able to target it when writing tests.
Comment 1 Radar WebKit Bug Importer 2019-03-04 12:35:17 PST
Comment 2 Devin Rousso 2019-03-04 13:16:16 PST
Created attachment 363546 [details]
Comment 3 Devin Rousso 2019-03-04 13:16:35 PST
Created attachment 363547 [details]
[Image] After Patch is applied
Comment 4 Matt Baker 2019-03-04 14:14:17 PST
Comment on attachment 363546 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=363546&action=review


> Source/WebInspectorUI/UserInterface/Views/AuditNavigationSidebarPanel.css:81
> +    font-size: 14px;

This should be 13px to match the font-size used for the body text of the "Editing Audits" .message-text-view element.
Comment 5 Devin Rousso 2019-03-04 14:19:06 PST
Created attachment 363551 [details]
Comment 6 WebKit Commit Bot 2019-03-04 14:57:18 PST
Comment on attachment 363551 [details]

Clearing flags on attachment: 363551

Committed r242395: <https://trac.webkit.org/changeset/242395>
Comment 7 WebKit Commit Bot 2019-03-04 14:57:20 PST
All reviewed patches have been landed.  Closing bug.