Bug 195239 - Web Inspector: Toggling Timeline "Stop when page loads" to on should stop (immediately or soon) any active recording if already past the load event
Summary: Web Inspector: Toggling Timeline "Stop when page loads" to on should stop (im...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-01 20:28 PST by Joseph Pecoraro
Modified: 2019-03-04 12:24 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.84 KB, patch)
2019-03-02 15:47 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (1.86 KB, patch)
2019-03-03 21:53 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2019-03-01 20:28:00 PST 
Toggling Timeline "Stop when page loads" to on should stop (immediately or soon) any active recording if already past the load event

I'd suggest if after load tickling the dead timeout so we would stop within 2s.
Comment 1 Devin Rousso 2019-03-02 15:47:17 PST 
Created attachment 363435 [details]
Patch
Comment 2 Devin Rousso 2019-03-03 21:53:12 PST 
Created attachment 363486 [details]
Patch
Comment 3 Joseph Pecoraro 2019-03-04 11:57:51 PST 
Comment on attachment 363486 [details]
Patch

r=me, Nice!
Comment 4 WebKit Commit Bot 2019-03-04 12:23:54 PST 
Comment on attachment 363486 [details]
Patch

Clearing flags on attachment: 363486

Committed r242370: <https://trac.webkit.org/changeset/242370>
Comment 5 WebKit Commit Bot 2019-03-04 12:23:56 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-03-04 12:24:55 PST 
<rdar://problem/48572456>