Bug 195232 - Web Inspector: Data grid border colors don't match accent colors
Summary: Web Inspector: Data grid border colors don't match accent colors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-01 15:48 PST by Nikita Vasilyev
Modified: 2019-03-01 16:45 PST (History)
4 users (show)

See Also:

Attachments
[Image] Bug (18.68 KB, image/png)
2019-03-01 15:48 PST, Nikita Vasilyev 		no flags Details
Patch (1.69 KB, patch)
2019-03-01 15:50 PST, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
[Image] With patch applied (22.03 KB, image/png)
2019-03-01 15:52 PST, Nikita Vasilyev 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2019-03-01 15:48:11 PST 
Created attachment 363383 [details]
[Image] Bug

Borders of selected items are always blue. It looks wrong with all accent colors except blue.
Comment 1 Nikita Vasilyev 2019-03-01 15:50:52 PST 
Created attachment 363384 [details]
Patch
Comment 2 Nikita Vasilyev 2019-03-01 15:52:24 PST 
Created attachment 363385 [details]
[Image] With patch applied
Comment 3 Matt Baker 2019-03-01 16:11:18 PST 
Comment on attachment 363384 [details]
Patch

r=me. I did a few spot checks, comparing selected rows in DataGrid and Table with a few accents and light/dark. Looks good!
Comment 4 WebKit Commit Bot 2019-03-01 16:37:24 PST 
Comment on attachment 363384 [details]
Patch

Clearing flags on attachment: 363384

Committed r242296: <https://trac.webkit.org/changeset/242296>
Comment 5 WebKit Commit Bot 2019-03-01 16:37:26 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-03-01 16:45:20 PST 
<rdar://problem/48528297>