Bug 195229 - Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
Summary: Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-01 14:25 PST by Alex Christensen
Modified: 2019-03-01 19:16 PST (History)
2 users (show)

See Also:

Attachments
Patch (11.22 KB, patch)
2019-03-01 14:28 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (14.14 KB, patch)
2019-03-01 14:56 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (15.25 KB, patch)
2019-03-01 16:39 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (15.25 KB, patch)
2019-03-01 18:16 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-03-01 14:25:14 PST 
Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
Comment 1 Alex Christensen 2019-03-01 14:28:51 PST 
Created attachment 363374 [details]
Patch
Comment 2 Alex Christensen 2019-03-01 14:56:01 PST 
Created attachment 363379 [details]
Patch
Comment 3 Alex Christensen 2019-03-01 16:39:23 PST 
Created attachment 363389 [details]
Patch
Comment 4 Chris Dumez 2019-03-01 16:52:26 PST 
Comment on attachment 363389 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363389&action=review

r=me but please check EWS.

> Source/WebKit/ChangeLog:12
> +        Functionality verified by manual testing.  See radar.

extra space.

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:203
> +    const String& sourceApplicationBundleIdentifier() { return m_sourceApplicationBundleIdentifier; }

const

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:206
> +    const String& sourceApplicationSecondaryIdentifier() { return m_sourceApplicationSecondaryIdentifier; }

const
Comment 5 Alex Christensen 2019-03-01 18:16:06 PST 
Created attachment 363393 [details]
Patch
Comment 6 Alex Christensen 2019-03-01 18:24:01 PST 
(In reply to Chris Dumez from comment #4)
> > Source/WebKit/ChangeLog:12
> > +        Functionality verified by manual testing.  See radar.
> 
> extra space.

I read https://en.wikipedia.org/wiki/Sentence_spacing and decided to stick with double space after the period.
Comment 7 Alex Christensen 2019-03-01 18:27:33 PST 
http://trac.webkit.org/r242302
Comment 8 Radar WebKit Bug Importer 2019-03-01 18:28:58 PST 
<rdar://problem/48530825>
Comment 10 Chris Dumez 2019-03-01 19:13:29 PST 
(In reply to Chris Dumez from comment #9)
> Broke the windows build:
> https://build.webkit.org/builders/WinCairo%2064-
> bit%20WKL%20Release%20%28Build%29/builds/7430/steps/compile-webkit/logs/stdio

Fix attempt: <https://trac.webkit.org/changeset/242305>
Comment 11 Chris Dumez 2019-03-01 19:14:33 PST 
I did say "Please watch EWS". GTK / WPE were red. Windows was also broken.
Comment 12 Alex Christensen 2019-03-01 19:16:40 PST 
:/
Thanks, Chris