Bug 195221 - [JSC] Use runtime calls for DFG MakeRope if !CPU(ADDRESS64)
Summary: [JSC] Use runtime calls for DFG MakeRope if !CPU(ADDRESS64)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-01 12:43 PST by Yusuke Suzuki
Modified: 2019-03-01 13:47 PST (History)
6 users (show)

See Also:

Attachments
Patch (18.05 KB, patch)
2019-03-01 12:45 PST, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-03-01 12:43:39 PST 
[JSC] Use runtime calls for DFG MakeRope if !CPU(ADDRESS64)
Comment 1 Yusuke Suzuki 2019-03-01 12:45:30 PST 
Created attachment 363358 [details]
Patch
Comment 2 Mark Lam 2019-03-01 12:54:52 PST 
Comment on attachment 363358 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363358&action=review

r=me

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:13400
> +    Edge edges[3] = {
> +        node->child1(),
> +        node->child2(),
> +        node->child3()
> +    };

This is only used by the CPU(ADDRESS64) case.  Can you move it in there?
Comment 3 Yusuke Suzuki 2019-03-01 13:32:03 PST 
Comment on attachment 363358 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363358&action=review

>> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:13400
>> +    };
> 
> This is only used by the CPU(ADDRESS64) case.  Can you move it in there?

Oops, fixed. Thanks.
Comment 4 Yusuke Suzuki 2019-03-01 13:46:13 PST 
Committed r242286: <https://trac.webkit.org/changeset/242286>
Comment 5 Radar WebKit Bug Importer 2019-03-01 13:47:16 PST 
<rdar://problem/48521543>