Bug 195172 - [ContentChangeObserver] Introduce observer subclasses to scope content change observing.
Summary: [ContentChangeObserver] Introduce observer subclasses to scope content change...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-28 10:29 PST by zalan
Modified: 2019-02-28 15:18 PST (History)
5 users (show)

See Also:

Attachments
Patch (10.42 KB, patch)
2019-02-28 10:34 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (10.52 KB, patch)
2019-02-28 14:51 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-02-28 10:29:23 PST 
instead of adding start/stops everywhere.
Comment 1 Radar WebKit Bug Importer 2019-02-28 10:32:16 PST 
<rdar://problem/48479259>
Comment 2 zalan 2019-02-28 10:34:25 PST 
Created attachment 363237 [details]
Patch
Comment 3 Simon Fraser (smfr) 2019-02-28 11:10:41 PST 
Comment on attachment 363237 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363237&action=review

> Source/WebCore/dom/Document.cpp:2058
> +    ContentChangeObserver::StyleRecalcObserver observer(page());

observingScope?

> Source/WebCore/page/ios/ContentChangeObserver.h:53
> +    class StyleChangeObserver {

StyleChangeScope
Comment 4 zalan 2019-02-28 14:51:12 PST 
Created attachment 363263 [details]
Patch
Comment 5 WebKit Commit Bot 2019-02-28 15:18:11 PST 
Comment on attachment 363263 [details]
Patch

Clearing flags on attachment: 363263

Committed r242234: <https://trac.webkit.org/changeset/242234>
Comment 6 WebKit Commit Bot 2019-02-28 15:18:13 PST 
All reviewed patches have been landed.  Closing bug.