Bug 194992 - [EME][GStreamer] Replace caps field loop with gst_structure_remove_fields
Summary: [EME][GStreamer] Replace caps field loop with gst_structure_remove_fields
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Charlie Turner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-24 10:06 PST by Charlie Turner
Modified: 2019-02-25 02:41 PST (History)
3 users (show)

See Also:

Attachments
Patch (4.26 KB, patch)
2019-02-24 10:09 PST, Charlie Turner 		no flags Details | Formatted Diff | Diff
Patch for landing (4.26 KB, patch)
2019-02-25 01:37 PST, Charlie Turner 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Charlie Turner 2019-02-24 10:06:40 PST 
[EME][GStreamer] Replace caps field loop with gst_structure_remove_fields
Comment 1 Charlie Turner 2019-02-24 10:09:41 PST 
Created attachment 362858 [details]
Patch
Comment 2 Xabier Rodríguez Calvar 2019-02-25 01:09:17 PST 
Comment on attachment 362858 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362858&action=review

> Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:130
> +            gst_structure_remove_fields(outgoingStructure.get(), "protection-system", "original-media-type", "encryption-algorithm", "encoding-scope", "cipher-mode", NULL);

nullptr

> Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:136
> +            gst_structure_remove_fields(outgoingStructure.get(), "base-profile", "codec_data", "height", "framerate", "level", "pixel-aspect-ratio", "profile", "rate", "width", NULL);

nullptr
Comment 3 Charlie Turner 2019-02-25 01:37:33 PST 
Created attachment 362889 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2019-02-25 02:15:37 PST 
Comment on attachment 362889 [details]
Patch for landing

Clearing flags on attachment: 362889

Committed r242035: <https://trac.webkit.org/changeset/242035>
Comment 5 WebKit Commit Bot 2019-02-25 02:15:38 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-02-25 02:41:19 PST 
<rdar://problem/48358301>