Bug 194964 - [iOS] Break a reference cycle between PreviewLoader and ResourceLoader
Summary: [iOS] Break a reference cycle between PreviewLoader and ResourceLoader
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on: 195057
Blocks:
  Show dependency tree / graph
 
Reported: 2019-02-22 15:59 PST by Andy Estes
Modified: 2019-03-25 18:20 PDT (History)
13 users (show)

See Also:

Attachments
Patch (1.66 KB, patch)
2019-02-22 16:04 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (9.12 KB, patch)
2019-03-25 14:40 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2019-02-22 15:59:24 PST 
[iOS] Break a reference cycle between PreviewLoader and ResourceLoader
Comment 1 Andy Estes 2019-02-22 16:00:24 PST 
rdar://problem/48279441
Comment 2 Andy Estes 2019-02-22 16:04:27 PST 
Created attachment 362776 [details]
Patch
Comment 3 WebKit Commit Bot 2019-02-22 16:42:04 PST 
Comment on attachment 362776 [details]
Patch

Clearing flags on attachment: 362776

Committed r241970: <https://trac.webkit.org/changeset/241970>
Comment 4 WebKit Commit Bot 2019-02-22 16:42:06 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Truitt Savell 2019-02-26 11:08:11 PST 
The change in https://trac.webkit.org/changeset/241970/webkit

caused the API test QuickLook.LegacyQuickLookContent 

to become flakey on iOS simulator. 

log:
https://build.webkit.org/builders/Apple%20iOS%2012%20Simulator%20Release%20WK2%20%28Tests%29/builds/2832/steps/run-api-tests/logs/stdio

Failed

    TestWebKitAPI.QuickLook.LegacyQuickLookContent
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:221
        Value of: [[NSFileManager defaultManager] fileExistsAtPath:filePath]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:226
        Expected equality of these values:
          expectedFileSize
            Which is: 274143
          [fileAttributes[NSFileSize] unsignedIntegerValue]
            Which is: 0

reproduced with command:
run-api-tests QuickLook.LegacyQuickLookContent --ios-simulator

the test will fail intermittently on r241970 but did not fail at all on r241969
Comment 6 WebKit Commit Bot 2019-02-26 11:20:09 PST 
Re-opened since this is blocked by bug 195057
Comment 7 Andy Estes 2019-03-25 14:40:30 PDT 
Created attachment 365902 [details]
Patch
Comment 8 WebKit Commit Bot 2019-03-25 16:30:52 PDT 
Comment on attachment 365902 [details]
Patch

Clearing flags on attachment: 365902

Committed r243471: <https://trac.webkit.org/changeset/243471>
Comment 9 WebKit Commit Bot 2019-03-25 16:30:54 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Fujii Hironori 2019-03-25 18:20:24 PDT 
Committed r243476: <https://trac.webkit.org/changeset/243476>