Bug 194868 - Resolve WebsiteDataStore/HTTPCookieStore ref cycle
Summary: Resolve WebsiteDataStore/HTTPCookieStore ref cycle
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-20 13:24 PST by Alex Christensen
Modified: 2019-02-20 16:14 PST (History)
3 users (show)

See Also:


Attachments
Patch (10.62 KB, patch)
2019-02-20 13:25 PST, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-02-20 13:24:53 PST
Resolve WebsiteDataStore/HTTPCookieStore ref cycle
Comment 1 Alex Christensen 2019-02-20 13:25:01 PST
Created attachment 362532 [details]
Patch
Comment 2 Geoffrey Garen 2019-02-20 13:52:24 PST
Comment on attachment 362532 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2019-02-20 14:22:29 PST
Comment on attachment 362532 [details]
Patch

Clearing flags on attachment: 362532

Committed r241838: <https://trac.webkit.org/changeset/241838>
Comment 4 WebKit Commit Bot 2019-02-20 14:22:30 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-02-20 14:24:47 PST
<rdar://problem/48251863>
Comment 6 Alex Christensen 2019-02-20 16:14:00 PST
Reverted in https://trac.webkit.org/changeset/241850/webkit

The first attempt caused crashes in these API tests:
    WebKit.CookieObserverCrash
    WebKit.WKHTTPCookieStoreWithoutProcessPoolWithPrewarming
    WebKit.WKHTTPCookieStoreWithoutProcessPoolWithoutPrewarming
Comment 7 Alex Christensen 2019-02-20 16:14:14 PST
Reopening