Bug 194763 - Update WebKit review policy to allow r- by non-reviewers
Summary: Update WebKit review policy to allow r- by non-reviewers
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-17 11:20 PST by Aakash Jain
Modified: 2019-02-18 13:16 PST (History)
9 users (show)

See Also:


Attachments
Proposed patch (1.79 KB, patch)
2019-02-17 17:07 PST, Aakash Jain
sam: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-02-17 11:20:53 PST
We should allow non-reviewers to set r- on patches. For e.g.: In case a reviewer who has no expertise in a particular tricky area of code (and so probably shouldn’t r+), notices an obvious error (e.g. a specific link that accesses memory out-of-bounds) it would be appropriate (but not required), for him/her to set r- on the patch.

This would help other reviewers with the review.
Comment 1 Aakash Jain 2019-02-17 17:07:56 PST
Created attachment 362262 [details]
Proposed patch
Comment 2 Sam Weinig 2019-02-17 17:27:16 PST
Comment on attachment 362262 [details]
Proposed patch

I disagree with this policy change. I think it makes it makes things more confusing for no real gain. Ideally, we should codify this rule by not allowing non-reviewers to change the review flag to r+ or r-.
Comment 3 Ryosuke Niwa 2019-02-18 13:16:03 PST
Seems like this is WontFix given the latest webkit-dev discussions.