Bug 194716 - Move service worker response validation from the service worker client to the service worker itself
Summary: Move service worker response validation from the service worker client to the...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on: 194651
Blocks:
  Show dependency tree / graph
 
Reported: 2019-02-15 11:57 PST by youenn fablet
Modified: 2019-02-26 15:54 PST (History)
5 users (show)

See Also:

Attachments
Patch (25.29 KB, patch)
2019-02-15 12:01 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-highsierra-wk2 (2.90 MB, application/zip)
2019-02-15 14:34 PST, EWS Watchlist 		no flags Details
Patch (25.97 KB, patch)
2019-02-15 15:56 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (19.71 KB, patch)
2019-02-15 20:43 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-02-15 11:57:24 PST 
Move service worker response validation from the service worker client to the service worker itself
Comment 1 youenn fablet 2019-02-15 12:01:47 PST 
Created attachment 362141 [details]
Patch
Comment 2 EWS Watchlist 2019-02-15 14:34:33 PST 
Comment on attachment 362141 [details]
Patch

Attachment 362141 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11163915

New failing tests:
http/tests/inspector/network/resource-response-service-worker.html
Comment 3 EWS Watchlist 2019-02-15 14:34:35 PST 
Created attachment 362159 [details]
Archive of layout-test-results from ews107 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6
Comment 4 youenn fablet 2019-02-15 15:56:05 PST 
Created attachment 362174 [details]
Patch
Comment 5 youenn fablet 2019-02-15 20:43:43 PST 
Created attachment 362203 [details]
Patch
Comment 6 Geoffrey Garen 2019-02-16 09:10:47 PST 
Comment on attachment 362203 [details]
Patch

r=me
Comment 7 WebKit Commit Bot 2019-02-26 15:53:28 PST 
Comment on attachment 362203 [details]
Patch

Clearing flags on attachment: 362203

Committed r242112: <https://trac.webkit.org/changeset/242112>
Comment 8 WebKit Commit Bot 2019-02-26 15:53:30 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-02-26 15:54:42 PST 
<rdar://problem/48419000>