Bug 194417 - Web Inspector: Make Timeline markers light gray instead of black in dark mode
Summary: Web Inspector: Make Timeline markers light gray instead of black in dark mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-07 16:11 PST by Joseph Pecoraro
Modified: 2019-02-07 17:02 PST (History)
6 users (show)

See Also:


Attachments
[IMAGE] Before (808.35 KB, image/png)
2019-02-07 16:11 PST, Joseph Pecoraro
no flags Details
[IMAGE] After (807.65 KB, image/png)
2019-02-07 16:11 PST, Joseph Pecoraro
no flags Details
[PATCH] Proposed Fix (1.99 KB, patch)
2019-02-07 16:12 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2019-02-07 16:11:12 PST
Make Timeline markers light gray instead of black in dark mode
Comment 1 Joseph Pecoraro 2019-02-07 16:11:32 PST
Created attachment 361463 [details]
[IMAGE] Before
Comment 2 Joseph Pecoraro 2019-02-07 16:11:43 PST
Created attachment 361464 [details]
[IMAGE] After
Comment 3 Joseph Pecoraro 2019-02-07 16:12:13 PST
Created attachment 361465 [details]
[PATCH] Proposed Fix
Comment 4 Nikita Vasilyev 2019-02-07 16:38:25 PST
Comment on attachment 361465 [details]
[PATCH] Proposed Fix

I'd r+. I wanted to fix this :)

Borders in Dark Mode should be lighter than the background.
Comment 5 Devin Rousso 2019-02-07 16:40:41 PST
Comment on attachment 361465 [details]
[PATCH] Proposed Fix

rs=me, WOW!  What a difference =D
Comment 6 WebKit Commit Bot 2019-02-07 17:01:20 PST
Comment on attachment 361465 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 361465

Committed r241175: <https://trac.webkit.org/changeset/241175>
Comment 7 WebKit Commit Bot 2019-02-07 17:01:21 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-02-07 17:02:32 PST
<rdar://problem/47903348>