Bug 194346 - Roll out parts of r238819 since it is a PLT performance regression.
Summary: Roll out parts of r238819 since it is a PLT performance regression.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-06 09:31 PST by Per Arne Vollan
Modified: 2019-02-06 11:52 PST (History)
3 users (show)

See Also:

Attachments
Patch (35.15 KB, patch)
2019-02-06 09:38 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2019-02-06 09:31:31 PST 
The other parts of r238819 has already been reverted in r240808.
Comment 1 Per Arne Vollan 2019-02-06 09:38:25 PST 
Created attachment 361300 [details]
Patch
Comment 2 Per Arne Vollan 2019-02-06 10:00:23 PST 
Committed r241026: <https://trac.webkit.org/changeset/241026/webkit>
Comment 3 Radar WebKit Bug Importer 2019-02-06 10:20:38 PST 
<rdar://problem/47854046>
Comment 4 Truitt Savell 2019-02-06 11:52:16 PST 
After this revert we have a timing out API test:

Timeout

    TestWebKitAPI.RenderingProgress.FirstMeaningfulPaint
        _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL.


build:
https://build.webkit.org/builders/Apple%20Mojave%20Release%20WK1%20%28Tests%29/builds/2759

verified this locally using run-api-tests on r241026. 241025 does not have the failure.