RESOLVED FIXED 194321
Move toNSEventModifierFlags() and toNSButtonNumber() to WebEventFactory.mm 
https://bugs.webkit.org/show_bug.cgi?id=194321
Summary Move toNSEventModifierFlags() and toNSButtonNumber() to WebEventFactory.mm
Daniel Bates
Reported 2019-02-05 17:31:45 PST
Move some helper functions, toNSEventModifierFlags() and toNSButtonNumber(), from WKNavigationAction.mm to WebEventFactory.mm.
Attachments
Patch (8.81 KB, patch)
2019-02-05 17:34 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (8.91 KB, patch)
2019-02-06 12:07 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (8.93 KB, patch)
2019-02-06 13:19 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (9.06 KB, patch)
2019-02-06 13:32 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (9.29 KB, patch)
2019-02-06 14:43 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2019-02-05 17:34:46 PST
Created attachment 361259 [details] Patch
Daniel Bates
Comment 2 2019-02-06 12:07:23 PST
Created attachment 361311 [details] Patch
Daniel Bates
Comment 3 2019-02-06 13:19:42 PST
Created attachment 361320 [details] Patch
Daniel Bates
Comment 4 2019-02-06 13:32:00 PST
Created attachment 361322 [details] Patch
Daniel Bates
Comment 5 2019-02-06 14:43:19 PST
Created attachment 361332 [details] Patch
Daniel Bates
Comment 6 2019-02-06 16:23:25 PST
Comment on attachment 361332 [details] Patch Clearing flags on attachment: 361332 Committed r241109: <https://trac.webkit.org/changeset/241109>
Daniel Bates
Comment 7 2019-02-06 16:23:27 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-02-06 16:24:29 PST
<rdar://problem/47869587>
Note You need to log in before you can comment on or make changes to this bug.