194321 – Move toNSEventModifierFlags() and toNSButtonNumber() to WebEventFactory.mm

Bug 194321 - Move toNSEventModifierFlags() and toNSButtonNumber() to WebEventFactory.mm

Summary: Move toNSEventModifierFlags() and toNSButtonNumber() to WebEventFactory.mm

Attachments
Patch (8.81 KB, patch) 2019-02-05 17:34 PST, Daniel Bates	no flags	Details \| Formatted Diff \| Diff
Patch (8.91 KB, patch) 2019-02-06 12:07 PST, Daniel Bates	no flags	Details \| Formatted Diff \| Diff
Patch (8.93 KB, patch) 2019-02-06 13:19 PST, Daniel Bates	no flags	Details \| Formatted Diff \| Diff
Patch (9.06 KB, patch) 2019-02-06 13:32 PST, Daniel Bates	no flags	Details \| Formatted Diff \| Diff
Patch (9.29 KB, patch) 2019-02-06 14:43 PST, Daniel Bates	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Daniel Bates 2019-02-05 17:31:45 PST

Move some helper functions, toNSEventModifierFlags() and toNSButtonNumber(), from WKNavigationAction.mm to WebEventFactory.mm.

Comment 1 Daniel Bates 2019-02-05 17:34:46 PST

Created attachment 361259 [details]
Patch

Comment 2 Daniel Bates 2019-02-06 12:07:23 PST

Created attachment 361311 [details]
Patch

Comment 3 Daniel Bates 2019-02-06 13:19:42 PST

Created attachment 361320 [details]
Patch

Comment 4 Daniel Bates 2019-02-06 13:32:00 PST

Created attachment 361322 [details]
Patch

Comment 5 Daniel Bates 2019-02-06 14:43:19 PST

Created attachment 361332 [details]
Patch

Comment 6 Daniel Bates 2019-02-06 16:23:25 PST

Comment on attachment 361332 [details]
Patch

Clearing flags on attachment: 361332

Committed r241109: <https://trac.webkit.org/changeset/241109>

Comment 7 Daniel Bates 2019-02-06 16:23:27 PST

All reviewed patches have been landed.  Closing bug.

Comment 8 Radar WebKit Bug Importer 2019-02-06 16:24:29 PST

<rdar://problem/47869587>