Bug 194317 - Standardize on ControlKey instead of CtrlKey
Summary: Standardize on ControlKey instead of CtrlKey
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-05 16:41 PST by Daniel Bates
Modified: 2019-02-06 13:27 PST (History)
8 users (show)

See Also:


Attachments
Patch (19.42 KB, patch)
2019-02-05 16:42 PST, Daniel Bates
no flags Details | Formatted Diff | Diff
Patch (22.23 KB, patch)
2019-02-06 12:03 PST, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2019-02-05 16:41:46 PST
Use the term "control key" instead of "ctrl key".
Comment 1 Daniel Bates 2019-02-05 16:42:56 PST
Created attachment 361245 [details]
Patch
Comment 2 Daniel Bates 2019-02-05 16:43:31 PST
We can't change the use of "ctrl" in the DOM, but we can standard on "control" everywhere else.
Comment 3 Daniel Bates 2019-02-06 12:03:32 PST
Created attachment 361310 [details]
Patch
Comment 4 Daniel Bates 2019-02-06 13:26:55 PST
Comment on attachment 361310 [details]
Patch

Clearing flags on attachment: 361310

Committed r241044: <https://trac.webkit.org/changeset/241044>
Comment 5 Daniel Bates 2019-02-06 13:26:56 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-02-06 13:27:29 PST
<rdar://problem/47861844>