Bug 193887 - [ews-build] Add build step to print bot Configuration
Summary: [ews-build] Add build step to print bot Configuration
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-27 12:35 PST by Aakash Jain
Modified: 2019-01-29 13:57 PST (History)
6 users (show)

See Also:


Attachments
Proposed patch (3.25 KB, patch)
2019-01-27 12:41 PST, Aakash Jain
lforschler: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-01-27 12:35:56 PST
We should add a build step in ews-build to print bot configuration (e.g.: Xcode version). This would help in debugging failures.
Comment 1 Aakash Jain 2019-01-27 12:41:55 PST
Created attachment 360306 [details]
Proposed patch

Sample run: https://ews-build.webkit-uat.org/#/builders/5/builds/1917
Comment 2 EWS Watchlist 2019-01-27 12:44:29 PST Comment hidden (obsolete)
Comment 3 Lucas Forschler 2019-01-28 11:34:06 PST
Comment on attachment 360306 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360306&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:759
> +

These commands will not work for any Windows EWS bots. We should probably do a platform check, or at least put in a #FIXME to indicate any non Mac/unix work needed.
(since halt/flunk/warn on failure is False, this won't break anything on those platforms...but it would be nice to do the right thing pending OS.
Comment 4 Aakash Jain 2019-01-28 15:09:36 PST Comment hidden (obsolete)
Comment 5 Radar WebKit Bug Importer 2019-01-28 15:10:28 PST Comment hidden (obsolete)
Comment 6 Aakash Jain 2019-01-29 13:57:26 PST
> put in a #FIXME to indicate any non Mac/unix work needed.
Done.
Comment 7 Aakash Jain 2019-01-29 13:57:44 PST
Committed r240680: <https://trac.webkit.org/changeset/240680>