WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
193887
[ews-build] Add build step to print bot Configuration
https://bugs.webkit.org/show_bug.cgi?id=193887
Summary
[ews-build] Add build step to print bot Configuration
Aakash Jain
Reported
2019-01-27 12:35:56 PST
We should add a build step in ews-build to print bot configuration (e.g.: Xcode version). This would help in debugging failures.
Attachments
Proposed patch
(3.25 KB, patch)
2019-01-27 12:41 PST
,
Aakash Jain
lforschler
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Aakash Jain
Comment 1
2019-01-27 12:41:55 PST
Created
attachment 360306
[details]
Proposed patch Sample run:
https://ews-build.webkit-uat.org/#/builders/5/builds/1917
EWS Watchlist
Comment 2
2019-01-27 12:44:29 PST
Comment hidden (obsolete)
Attachment 360306
[details]
did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:23: No name 'plugins' in module 'buildbot' [pylint/E0611] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:760: [PrintConfiguration.__init__] Use of super on an old style class [pylint/E1002] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Lucas Forschler
Comment 3
2019-01-28 11:34:06 PST
Comment on
attachment 360306
[details]
Proposed patch View in context:
https://bugs.webkit.org/attachment.cgi?id=360306&action=review
> Tools/BuildSlaveSupport/ews-build/steps.py:759 > +
These commands will not work for any Windows EWS bots. We should probably do a platform check, or at least put in a #FIXME to indicate any non Mac/unix work needed. (since halt/flunk/warn on failure is False, this won't break anything on those platforms...but it would be nice to do the right thing pending OS.
Aakash Jain
Comment 4
2019-01-28 15:09:36 PST
Comment hidden (obsolete)
Committed
r240605
: <
https://trac.webkit.org/changeset/240605
>
Radar WebKit Bug Importer
Comment 5
2019-01-28 15:10:28 PST
Comment hidden (obsolete)
<
rdar://problem/47612832
>
Aakash Jain
Comment 6
2019-01-29 13:57:26 PST
> put in a #FIXME to indicate any non Mac/unix work needed.
Done.
Aakash Jain
Comment 7
2019-01-29 13:57:44 PST
Committed
r240680
: <
https://trac.webkit.org/changeset/240680
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug