Bug 193640 - Rollout r240210: It broke tests on iOS
Summary: Rollout r240210: It broke tests on iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks: 192782
  Show dependency tree / graph
 
Reported: 2019-01-20 19:19 PST by Saam Barati
Modified: 2019-01-20 20:38 PST (History)
3 users (show)

See Also:

Attachments
patch for landing (132.55 KB, patch)
2019-01-20 19:24 PST, Saam Barati 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
patch for landing (132.52 KB, patch)
2019-01-20 19:58 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2019-01-20 19:19:35 PST 
...
Comment 1 Saam Barati 2019-01-20 19:24:26 PST 
Created attachment 359665 [details]
patch for landing
Comment 2 WebKit Commit Bot 2019-01-20 19:50:04 PST 
Comment on attachment 359665 [details]
patch for landing

Rejecting attachment 359665 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 359665, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WTF/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/10824700
Comment 3 Saam Barati 2019-01-20 19:58:35 PST 
Created attachment 359666 [details]
patch for landing
Comment 4 WebKit Commit Bot 2019-01-20 20:37:09 PST 
Comment on attachment 359666 [details]
patch for landing

Clearing flags on attachment: 359666

Committed r240224: <https://trac.webkit.org/changeset/240224>
Comment 5 WebKit Commit Bot 2019-01-20 20:37:11 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-01-20 20:38:29 PST 
<rdar://problem/47420043>