Bug 193578 - Regression(PSON) Scroll position is not always restored properly when navigating back
Summary: Regression(PSON) Scroll position is not always restored properly when navigat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-18 09:15 PST by Chris Dumez
Modified: 2019-01-18 11:47 PST (History)
7 users (show)

See Also:

Attachments
Patch (13.99 KB, patch)
2019-01-18 09:40 PST, Chris Dumez 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-01-18 09:15:17 PST 
Scroll position is not always restored properly when navigating back, when PSON is enabled.
Comment 1 Radar WebKit Bug Importer 2019-01-18 09:15:44 PST 
<rdar://problem/47386331>
Comment 2 Chris Dumez 2019-01-18 09:40:54 PST 
Created attachment 359499 [details]
Patch
Comment 3 EWS Watchlist 2019-01-18 09:44:07 PST 
Attachment 359499 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:3849:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:3853:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:3866:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 3 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Tim Horton 2019-01-18 11:24:44 PST 
Comment on attachment 359499 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359499&action=review

> Source/WebKit/ChangeLog:42
> +        not cause a flash in most cases. Howerver, with PSON enabled and the layer tree freezing we

Howerver
Comment 5 Chris Dumez 2019-01-18 11:47:38 PST 
Committed r240161: <https://trac.webkit.org/changeset/240161>