RESOLVED FIXED193528
[LFC][BFC][Quirk] Take body padding and border into account when stretching height. 
https://bugs.webkit.org/show_bug.cgi?id=193528
Summary [LFC][BFC][Quirk] Take body padding and border into account when stretching h...
alan
Reported 2019-01-16 22:08:44 PST
ssia
Attachments
Patch (6.30 KB, patch)
2019-01-16 22:14 PST, alan 		koivisto: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2019-01-16 22:14:53 PST
Created attachment 359351 [details] Patch
WebKit Commit Bot
Comment 2 2019-01-17 08:01:07 PST
Comment on attachment 359351 [details] Patch Rejecting attachment 359351 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 359351, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=359351&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=193528&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 359351 from bug 193528. Fetching: https://bugs.webkit.org/attachment.cgi?id=359351 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antti Koivisto']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 5 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/layout/blockformatting/BlockFormattingContextQuirks.cpp patching file Source/WebCore/layout/displaytree/DisplayBox.h patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/LayoutReloaded/misc/LFC-passing-tests.txt Hunk #1 FAILED at 90. 1 out of 1 hunk FAILED -- saving rejects to file Tools/LayoutReloaded/misc/LFC-passing-tests.txt.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antti Koivisto']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 5 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/layout/blockformatting/BlockFormattingContextQuirks.cpp patching file Source/WebCore/layout/displaytree/DisplayBox.h patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/LayoutReloaded/misc/LFC-passing-tests.txt Hunk #1 FAILED at 90. 1 out of 1 hunk FAILED -- saving rejects to file Tools/LayoutReloaded/misc/LFC-passing-tests.txt.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antti Koivisto']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource From https://git.webkit.org/git/WebKit d2c08c56397..1aced4fa833 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 240107 = d2c08c563972982a9074a7334d0aa0da79da2551 r240108 = 1aced4fa8335c27b41a7417660ecbcc14b001d34 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: https://webkit-queues.webkit.org/results/10784226
alan
Comment 3 2019-01-17 08:06:30 PST
Committed r240109: <https://trac.webkit.org/changeset/240109>
Radar WebKit Bug Importer
Comment 4 2019-01-17 08:07:28 PST
<rdar://problem/47351324>
Note You need to log in before you can comment on or make changes to this bug.