Bug 193503 - Build fix for iOSMac Reveal
Summary: Build fix for iOSMac Reveal
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-16 12:09 PST by Megan Gardner
Modified: 2019-01-16 15:45 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.11 KB, patch)
2019-01-16 12:10 PST, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch for landing (1.10 KB, patch)
2019-01-16 12:10 PST, Megan Gardner 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2019-01-16 12:09:38 PST 
Build fix for iOSMac Reveal
Comment 1 Megan Gardner 2019-01-16 12:10:11 PST 
Created attachment 359289 [details]
Patch
Comment 2 Megan Gardner 2019-01-16 12:10:59 PST 
Created attachment 359290 [details]
Patch for landing
Comment 3 WebKit Commit Bot 2019-01-16 12:48:54 PST 
Comment on attachment 359290 [details]
Patch for landing

Clearing flags on attachment: 359290

Committed r240048: <https://trac.webkit.org/changeset/240048>
Comment 4 WebKit Commit Bot 2019-01-16 12:48:56 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-01-16 12:49:29 PST 
<rdar://problem/47326303>
Comment 6 Alexey Proskuryakov 2019-01-16 15:44:12 PST 
Comment on attachment 359290 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=359290&action=review

> Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:26
> +#if PLATFORM(IOSMAC)

Is nothing in this file ever needed on iOS? Its name and location seem to suggest otherwise.
Comment 7 Megan Gardner 2019-01-16 15:45:11 PST 
This was wrong, Tim fixed it.