WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
193503
Build fix for iOSMac Reveal
https://bugs.webkit.org/show_bug.cgi?id=193503
Summary
Build fix for iOSMac Reveal
Megan Gardner
Reported
2019-01-16 12:09:38 PST
Build fix for iOSMac Reveal
Attachments
Patch
(1.11 KB, patch)
2019-01-16 12:10 PST
,
Megan Gardner
no flags
Details
Formatted Diff
Diff
Patch for landing
(1.10 KB, patch)
2019-01-16 12:10 PST
,
Megan Gardner
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Megan Gardner
Comment 1
2019-01-16 12:10:11 PST
Created
attachment 359289
[details]
Patch
Megan Gardner
Comment 2
2019-01-16 12:10:59 PST
Created
attachment 359290
[details]
Patch for landing
WebKit Commit Bot
Comment 3
2019-01-16 12:48:54 PST
Comment on
attachment 359290
[details]
Patch for landing Clearing flags on attachment: 359290 Committed
r240048
: <
https://trac.webkit.org/changeset/240048
>
WebKit Commit Bot
Comment 4
2019-01-16 12:48:56 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5
2019-01-16 12:49:29 PST
<
rdar://problem/47326303
>
Alexey Proskuryakov
Comment 6
2019-01-16 15:44:12 PST
Comment on
attachment 359290
[details]
Patch for landing View in context:
https://bugs.webkit.org/attachment.cgi?id=359290&action=review
> Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:26 > +#if PLATFORM(IOSMAC)
Is nothing in this file ever needed on iOS? Its name and location seem to suggest otherwise.
Megan Gardner
Comment 7
2019-01-16 15:45:11 PST
This was wrong, Tim fixed it.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug