Bug 193470 - [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
Summary: [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-15 16:05 PST by zalan
Modified: 2019-01-16 07:24 PST (History)
6 users (show)

See Also:

Attachments
Patch (6.29 KB, patch)
2019-01-15 16:15 PST, zalan 		koivisto: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-01-15 16:05:05 PST 
Missed the case when both computed values are non-auto.
Comment 1 zalan 2019-01-15 16:15:36 PST 
Created attachment 359217 [details]
Patch
Comment 2 WebKit Commit Bot 2019-01-16 07:03:19 PST 
Comment on attachment 359217 [details]
Patch

Rejecting attachment 359217 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 359217, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=359217&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=193470&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 359217 from bug 193470.
Fetching: https://bugs.webkit.org/attachment.cgi?id=359217
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antti Koivisto']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 7 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/layout/FormattingContextGeometry.cpp
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/LayoutReloaded/misc/LFC-passing-tests.txt
Hunk #1 FAILED at 79.
1 out of 1 hunk FAILED -- saving rejects to file Tools/LayoutReloaded/misc/LFC-passing-tests.txt.rej
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/fast/block/block-only/non-auto-top-bottom-height-with-margins-expected.txt
patching file LayoutTests/fast/block/block-only/non-auto-top-bottom-height-with-margins.html

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antti Koivisto']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/10771932
Comment 3 zalan 2019-01-16 07:23:33 PST 
Committed r240036: <https://trac.webkit.org/changeset/240036>
Comment 4 Radar WebKit Bug Importer 2019-01-16 07:24:42 PST 
<rdar://problem/47316008>