Bug 193290 - Make didCommitChangesForLayer() explicitly about the platform layer changing
Summary: Make didCommitChangesForLayer() explicitly about the platform layer changing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-09 11:38 PST by Simon Fraser (smfr)
Modified: 2019-01-16 12:42 PST (History)
7 users (show)

See Also:

Attachments
Patch (13.13 KB, patch)
2019-01-09 11:42 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (3.52 MB, application/zip)
2019-01-09 13:46 PST, EWS Watchlist 		no flags Details
Patch (14.08 KB, patch)
2019-01-15 19:03 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (16.21 MB, application/zip)
2019-01-15 20:53 PST, EWS Watchlist 		no flags Details
Patch (17.14 KB, patch)
2019-01-16 12:02 PST, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2019-01-09 11:38:37 PST 
Make didCommitChangesForLayer() explicitly about the platform layer changing because of tile/non-tile swapping
Comment 1 Simon Fraser (smfr) 2019-01-09 11:42:11 PST 
Created attachment 358718 [details]
Patch
Comment 2 EWS Watchlist 2019-01-09 13:46:33 PST Comment hidden (obsolete)
Comment 3 EWS Watchlist 2019-01-09 13:46:35 PST Comment hidden (obsolete)
Comment 4 Simon Fraser (smfr) 2019-01-15 19:03:24 PST 
Created attachment 359242 [details]
Patch
Comment 5 EWS Watchlist 2019-01-15 20:53:34 PST 
Comment on attachment 359242 [details]
Patch

Attachment 359242 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10767801

New failing tests:
transforms/2d/preserve3d-not-fixed-container.html
Comment 6 EWS Watchlist 2019-01-15 20:53:36 PST 
Created attachment 359253 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 7 Simon Fraser (smfr) 2019-01-16 12:02:05 PST 
Created attachment 359288 [details]
Patch
Comment 8 Tim Horton 2019-01-16 12:36:23 PST 
Comment on attachment 359288 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359288&action=review

> Source/WebCore/rendering/RenderLayerCompositor.cpp:549
> +    // FIXME: right?

????
Comment 9 Simon Fraser (smfr) 2019-01-16 12:41:31 PST 
https://trac.webkit.org/r240047
Comment 10 Radar WebKit Bug Importer 2019-01-16 12:42:38 PST 
<rdar://problem/47326070>