RESOLVED FIXED193290
Make didCommitChangesForLayer() explicitly about the platform layer changing 
https://bugs.webkit.org/show_bug.cgi?id=193290
Summary Make didCommitChangesForLayer() explicitly about the platform layer changing
Simon Fraser (smfr)
Reported 2019-01-09 11:38:37 PST
Make didCommitChangesForLayer() explicitly about the platform layer changing because of tile/non-tile swapping
Attachments
Patch (13.13 KB, patch)
2019-01-09 11:42 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (3.52 MB, application/zip)
2019-01-09 13:46 PST, EWS Watchlist 		no flags
Details
Patch (14.08 KB, patch)
2019-01-15 19:03 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (16.21 MB, application/zip)
2019-01-15 20:53 PST, EWS Watchlist 		no flags
Details
Patch (17.14 KB, patch)
2019-01-16 12:02 PST, Simon Fraser (smfr) 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2019-01-09 11:42:11 PST
Created attachment 358718 [details] Patch
EWS Watchlist
Comment 2 2019-01-09 13:46:33 PST Comment hidden (obsolete)
EWS Watchlist
Comment 3 2019-01-09 13:46:35 PST Comment hidden (obsolete)
Simon Fraser (smfr)
Comment 4 2019-01-15 19:03:24 PST
Created attachment 359242 [details] Patch
EWS Watchlist
Comment 5 2019-01-15 20:53:34 PST
Comment on attachment 359242 [details] Patch Attachment 359242 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10767801 New failing tests: transforms/2d/preserve3d-not-fixed-container.html
EWS Watchlist
Comment 6 2019-01-15 20:53:36 PST
Created attachment 359253 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Simon Fraser (smfr)
Comment 7 2019-01-16 12:02:05 PST
Created attachment 359288 [details] Patch
Tim Horton
Comment 8 2019-01-16 12:36:23 PST
Comment on attachment 359288 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359288&action=review > Source/WebCore/rendering/RenderLayerCompositor.cpp:549 > + // FIXME: right? ????
Simon Fraser (smfr)
Comment 9 2019-01-16 12:41:31 PST
https://trac.webkit.org/r240047
Radar WebKit Bug Importer
Comment 10 2019-01-16 12:42:38 PST
<rdar://problem/47326070>
Note You need to log in before you can comment on or make changes to this bug.