Bug 193003 - Only hyphenate text for which there is a language specified
Summary: Only hyphenate text for which there is a language specified
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks: 193002
  Show dependency tree / graph
 
Reported: 2018-12-21 19:55 PST by Myles C. Maxfield
Modified: 2021-11-01 12:18 PDT (History)
4 users (show)

See Also:

Attachments
Patch (8.85 KB, patch)
2018-12-21 19:58 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (6.42 KB, patch)
2018-12-21 20:17 PST, Myles C. Maxfield 		ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-sierra (2.44 MB, application/zip)
2018-12-21 21:18 PST, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews112 for mac-sierra (1.97 MB, application/zip)
2018-12-21 22:08 PST, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.72 MB, application/zip)
2018-12-21 22:15 PST, EWS Watchlist 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2018-12-21 19:55:52 PST 
Only hyphenate text for which there is a language specified
Comment 1 Myles C. Maxfield 2018-12-21 19:58:25 PST 
Created attachment 358015 [details]
Patch
Comment 2 Myles C. Maxfield 2018-12-21 20:17:54 PST 
Created attachment 358016 [details]
Patch
Comment 3 EWS Watchlist 2018-12-21 21:18:31 PST 
Comment on attachment 358016 [details]
Patch

Attachment 358016 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/10515819

New failing tests:
editing/spelling/spelling-marker-includes-hyphen.html
Comment 4 EWS Watchlist 2018-12-21 21:18:33 PST 
Created attachment 358017 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 5 EWS Watchlist 2018-12-21 22:08:25 PST 
Comment on attachment 358016 [details]
Patch

Attachment 358016 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/10515896

New failing tests:
editing/spelling/spelling-marker-includes-hyphen.html
Comment 6 EWS Watchlist 2018-12-21 22:08:27 PST 
Created attachment 358018 [details]
Archive of layout-test-results from ews112 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 7 EWS Watchlist 2018-12-21 22:15:11 PST 
Comment on attachment 358016 [details]
Patch

Attachment 358016 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10516088

New failing tests:
imported/w3c/web-platform-tests/webrtc/simplecall-no-ssrcs.https.html
editing/spelling/spelling-marker-includes-hyphen.html
Comment 8 EWS Watchlist 2018-12-21 22:15:13 PST 
Created attachment 358020 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 9 Alex Christensen 2021-11-01 12:18:13 PDT 
Comment on attachment 358016 [details]
Patch

This has been requesting review for more than one year.  If this is still needed, please rebase and re-request review.